test(litellm): cover Responses named tool choice (#2953) - #2957
Merged
nicoloboschi merged 1 commit intoJul 27, 2026
Merged
Conversation
nicoloboschi
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hindsight sends named tool choices to LiteLLM using the Chat Completions shape:
{"type":"function","function":{"name":"recall"}}Responses-compatible endpoints instead require the function name at the top level (#2953).
Root cause
Hindsight correctly passes the canonical Chat Completions shape to
litellm.acompletion(). Since #2950, the API requires LiteLLM 1.93.0 or newer; that version already includes the upstream Responses bridge normalization from BerriAI/litellm#27634, which rewrites the named choice before sending it to/responses.Adding a second serializer in Hindsight would duplicate upstream routing logic and risk the two implementations drifting.
Change
Add focused regression coverage for both wire formats:
litellm.aresponses()with{"type":"function","name":"recall"}.{"type":"function","function":{"name":"recall"}}.The Responses test exercises Hindsight's real
call_with_tools()->litellm.acompletion()-> Responses bridge path, mocking only the downstream provider request.Validation
Closes #2953.