Skip to content

fix(cli): preserve HTTP 400 details - #2916

Merged
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
koriyoshi2041:fix/2912-surface-http-errors
Jul 24, 2026
Merged

fix(cli): preserve HTTP 400 details#2916
nicoloboschi merged 2 commits into
vectorize-io:mainfrom
koriyoshi2041:fix/2912-surface-http-errors

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

Tests

  • cargo test --manifest-path hindsight-cli/Cargo.toml --bin hindsight (70 passed)
  • git diff --check

The repository-wide formatting check currently reports pre-existing formatting drift outside this change.

Closes #2912

@koriyoshi2041

Copy link
Copy Markdown
Contributor Author

The generated-files failure appears transient or environment-specific. On the exact PR head 3fc58621a, I ran:

./scripts/generate-openapi.sh
./scripts/generate-docs-skill.sh
git status --short

The working tree stayed clean. CI reported only a 2-line change in skills/hindsight-docs/references/openapi.json, while the source and generated copy are byte-identical locally. I don't have permission to rerun the repository workflow; a rerun should distinguish nondeterministic generation from a persistent Linux-only difference.

@koriyoshi2041

Copy link
Copy Markdown
Contributor Author

Correction after reproducing from a fresh detached worktree at exact head 3fc58621a:

The failure is deterministic and comes from the current base, not this CLI patch. The two committed OpenAPI copies already differ before generation:

-    "version": "0.8.5"
+    "version": "0.8.4"

hindsight-docs/static/openapi.json is 0.8.5, while skills/hindsight-docs/references/openapi.json is 0.8.4. Current main at 4dc834834 has the same mismatch. generate-docs-skill.sh copies the 0.8.5 source into the skill, producing the CI job's exact one-line diff.

So a rerun alone will remain red until the generated skill copy is refreshed on main or this branch is updated after that base fix. I am not adding the unrelated generated-file change to this focused CLI PR unless maintainers prefer that.

@nicoloboschi
nicoloboschi merged commit 1ff09cc into vectorize-io:main Jul 24, 2026
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory retain prints "Request timed out" (0s) for an HTTP 400 batch-mode rejection — swallows the self-explanatory error body

2 participants