Skip to content

fix(claude-code): skip duplicate recall banks - #2624

Closed
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/skip-duplicate-claude-recall-banks
Closed

fix(claude-code): skip duplicate recall banks#2624
koriyoshi2041 wants to merge 1 commit into
vectorize-io:mainfrom
koriyoshi2041:rios/skip-duplicate-claude-recall-banks

Conversation

@koriyoshi2041

Copy link
Copy Markdown
Contributor

Summary

  • skip recallAdditionalBanks entries that repeat the primary Claude Code memory bank
  • de-duplicate repeated additional bank IDs while preserving order
  • add a regression test for primary-bank and repeated extra-bank entries

Closes #2604

Test

  • uv run pytest hindsight-integrations/claude-code/tests/test_hooks.py::TestRecallHook::test_additional_banks_skip_primary_and_duplicates -q
  • uv run pytest hindsight-integrations/claude-code/tests/test_hooks.py -q
  • uv run ruff format --check hindsight-integrations/claude-code/scripts/recall.py hindsight-integrations/claude-code/tests/test_hooks.py
  • uv run ruff check hindsight-integrations/claude-code/scripts/recall.py hindsight-integrations/claude-code/tests/test_hooks.py
  • git diff --check

@koriyoshi2041

Copy link
Copy Markdown
Contributor Author

Closing this in favor of #2625, which covers the same recallAdditionalBanks duplicate/primary-bank case and is already green. Thanks for picking it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

claude-code plugin: recallAdditionalBanks re-recalls the primary bank when it appears in the list

1 participant