fix(claude-code): dedupe additional bank recall calls - #2616
Conversation
|
thanks for this — closing as superseded. #2625 landed the recallAdditionalBanks dedup (skip the primary + repeated bank ids) and it's already shipped in claude-code v0.7.4, so the core of this is covered. one thing your version does that #2625 doesn't: you key on (bank + tags + tag_groups + tags_match) rather than bank id alone, so the same bank listed twice with different filters would still fire both calls. that's a real (if narrow) distinction — but recallAdditionalBanks doesn't attach per-entry filters that way today (per-bank filters come from recallAdditionalBankFilters keyed by bank id, one per bank), so in practice the two collapse to the same behavior. if you think there's a config shape where the finer key matters, happy to look at a focused follow-up. appreciate the malformed-results guard too — if you want that hardening on its own, that'd be a clean standalone PR. |
Summary
resultsas an empty compatible responseFixes #2604.
Tests
python3 -m py_compile hindsight-integrations/claude-code/scripts/recall.py hindsight-integrations/claude-code/tests/test_hooks.pypython3 -m pytest hindsight-integrations/claude-code/tests/test_hooks.py -q(46 passed)git diff --check/tmp/codex-review-hindsight-2604-v12.final.txt)