Skip to content

fix(claude-code): dedupe additional bank recall calls - #2616

Closed
r266-tech wants to merge 1 commit into
vectorize-io:mainfrom
r266-tech:r266/claude-code-recall-additional-banks-dedupe-2604
Closed

fix(claude-code): dedupe additional bank recall calls#2616
r266-tech wants to merge 1 commit into
vectorize-io:mainfrom
r266-tech:r266/claude-code-recall-additional-banks-dedupe-2604

Conversation

@r266-tech

Copy link
Copy Markdown
Contributor

Summary

  • dedupe Claude Code additional-bank recall calls by bank plus effective filter state
  • preserve distinct same-bank recalls when filters differ
  • keep malformed or failed recall attempts retryable while treating missing results as an empty compatible response

Fixes #2604.

Tests

  • python3 -m py_compile hindsight-integrations/claude-code/scripts/recall.py hindsight-integrations/claude-code/tests/test_hooks.py
  • python3 -m pytest hindsight-integrations/claude-code/tests/test_hooks.py -q (46 passed)
  • git diff --check
  • Codex adversarial review: approve (/tmp/codex-review-hindsight-2604-v12.final.txt)

@benfrank241

Copy link
Copy Markdown
Member

thanks for this — closing as superseded. #2625 landed the recallAdditionalBanks dedup (skip the primary + repeated bank ids) and it's already shipped in claude-code v0.7.4, so the core of this is covered.

one thing your version does that #2625 doesn't: you key on (bank + tags + tag_groups + tags_match) rather than bank id alone, so the same bank listed twice with different filters would still fire both calls. that's a real (if narrow) distinction — but recallAdditionalBanks doesn't attach per-entry filters that way today (per-bank filters come from recallAdditionalBankFilters keyed by bank id, one per bank), so in practice the two collapse to the same behavior. if you think there's a config shape where the finer key matters, happy to look at a focused follow-up.

appreciate the malformed-results guard too — if you want that hardening on its own, that'd be a clean standalone PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

claude-code plugin: recallAdditionalBanks re-recalls the primary bank when it appears in the list

2 participants