chore(claude-code): drop opinionated bankMission/retainMission defaults (#2492) - #2494
Closed
nicolas-vivot wants to merge 1 commit into
Closed
Conversation
…ts (vectorize-io#2492) The bundled settings.json shipped non-empty bankMission/retainMission defaults, so a default install stamped a generic persona onto a bank on first touch — the trigger for the mission-clobber reported in vectorize-io#2492. Blank both (matching the internal config.py defaults: "" and null) so the plugin only seeds missions the user explicitly configures. Behaviour is unchanged when the fields are empty: bank.py already treats an empty/None mission as opt-out and sends nothing. This is the defaults-removal half of vectorize-io#2492, kept separate from the server-aware seeding fix so each can be adopted independently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nicoloboschi
requested changes
Jul 20, 2026
nicoloboschi
left a comment
nicoloboschi
left a comment
Collaborator
There was a problem hiding this comment.
we should document it, not changing the default, thanks
Contributor
Author
|
@nicoloboschi Got it. Could you have a look at this one? (the real fix / non optional fix IMO) (fixes this reported issue) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #2492. Removes the opinionated
bankMission/retainMissiondefaults shipped in the Claude Code plugin'ssettings.json, which are what triggered the mission-clobber for default installs.The bundled
settings.jsonshipped:So any default install stamped a generic persona onto a bank the first time the plugin touched it — overwriting per-bank missions authored via the control plane / API. This blanks both to match the plugin's own internal defaults (
config.py:bankMission="",retainMission=None), so the plugin only seeds missions the user explicitly configures.Changes
settings.json—bankMission: "",retainMission: null.README.md— config table default column updated to""/null(unset), documenting opt-in seeding.CHANGELOG.md—Changedentry.Behaviour
No behavioural change when the fields are empty:
bank.pyalready treats an empty/Nonemission as an opt-out and sends nothing.""vsnullis a typing convention only (bankMissionis astr,retainMissionisOptional[str]) — both are falsy and indistinguishable to the code.Relationship to the other PR
This is the defaults-removal half of #2492, deliberately kept separate from the server-aware seeding fix (#2493) so each can be adopted independently:
ensure_bank_missionserver-aware (never overwrites an existing per-bank mission). Fixes the clobber even for users who keep non-empty missions configured.Note: #2493 and this PR touch adjacent regions of
README.md/CHANGELOG.md; depending on merge order a trivial conflict may need resolving.Tests
Full Claude Code plugin suite passes (192 tests);
settings.jsonvalidated as JSON.