Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update minikube to 1.15.1 #4055

Merged
merged 4 commits into from
Nov 17, 2020
Merged

chore: Update minikube to 1.15.1 #4055

merged 4 commits into from
Nov 17, 2020

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Sep 22, 2020

1.13.1 update seems problematic at the moment, this PR exists to gather some data through our CI runs.
1.40 was also problematic.
We're looking into updating to 1.15.1 now.

Upstream tracking issue: kubernetes/minikube#9304

@MOZGIII MOZGIII added the ci-condition: k8s e2e all targets Run Kubernetes E2E test suite for all targets (instead of just the essential subset) label Sep 22, 2020
@MOZGIII MOZGIII changed the title chore: Update minikube to 1.13.1 chore: Update minikube to 1.14.0 Oct 15, 2020
@MOZGIII
Copy link
Contributor Author

MOZGIII commented Oct 16, 2020

CRI-O is broken at 1.40.0: https://github.com/timberio/vector/pull/4055/checks?check_run_id=1262088375
1.13.1, as I recall, has a different problem... Nope, same thing.

@jamtur01
Copy link
Contributor

@MOZGIII Is this still blocked?

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Nov 5, 2020

Update: fix was merged at upstream yesterday, waiting for the next minikube release (1.15?) and we should be good to go.

@jamtur01
Copy link
Contributor

@MOZGIII I see minikube 1.15 has been released.

@MOZGIII MOZGIII changed the title chore: Update minikube to 1.14.0 chore: Update minikube to 1.15.1 Nov 17, 2020
@MOZGIII MOZGIII marked this pull request as ready for review November 17, 2020 14:08
@MOZGIII MOZGIII removed the request for review from binarylogic November 17, 2020 14:09
Copy link
Contributor

@jamtur01 jamtur01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MOZGIII MOZGIII merged commit cb6d7a7 into master Nov 17, 2020
@MOZGIII MOZGIII deleted the minikube-update branch November 17, 2020 14:37
casserni pushed a commit that referenced this pull request Nov 20, 2020
* Bump minikube to 1.13.1 that resolves the bug

Signed-off-by: MOZGIII <[email protected]>

* Update minikube note at CONTRIBUTING.md

Signed-off-by: MOZGIII <[email protected]>

* Bump minikube to 1.14.0

Signed-off-by: MOZGIII <[email protected]>

* Bump minikube to 1.15.1

Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: casserni <[email protected]>
mengesb pushed a commit to jacobbraaten/vector that referenced this pull request Dec 9, 2020
* Bump minikube to 1.13.1 that resolves the bug

Signed-off-by: MOZGIII <[email protected]>

* Update minikube note at CONTRIBUTING.md

Signed-off-by: MOZGIII <[email protected]>

* Bump minikube to 1.14.0

Signed-off-by: MOZGIII <[email protected]>

* Bump minikube to 1.15.1

Signed-off-by: MOZGIII <[email protected]>
Signed-off-by: Brian Menges <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-condition: k8s e2e all targets Run Kubernetes E2E test suite for all targets (instead of just the essential subset)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants