feat(gcp_cloud_storage sink): add content_type option#24477
Merged
thomasqueirozb merged 2 commits intovectordotdev:masterfrom Jan 15, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
drichards-87
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR Adds a "content_type" configuration option to the "gcp_cloud_storage" sink to allow overriding the MIME type set on uploaded GCS objects (e.g.
text/plain; charset=utf-8). When not specified, the sink continues to use the encoder-derived content type which is the existing behavior.Vector configuration
How did you test this PR?
Ran unit tests:
Manual verification:
Ran Vector locally and confirmed newly created objects in GCS had:
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.AI Assistance
Cursor AI : GPT-5 to check if any corner cases exists. Make sure my style is not out of order with existing style
References