Skip to content

fix(metrics): absolute to incremental histogram conversion#24472

Merged
thomasqueirozb merged 2 commits intomasterfrom
sebastien.lubineau/fix-24415
Jan 15, 2026
Merged

fix(metrics): absolute to incremental histogram conversion#24472
thomasqueirozb merged 2 commits intomasterfrom
sebastien.lubineau/fix-24415

Conversation

@dd-sebastien-lb
Copy link
Contributor

@dd-sebastien-lb dd-sebastien-lb commented Jan 9, 2026

Summary

This PR aims to provide a solution to issue #24415.

Vector configuration

How did you test this PR?

The issue describe an error occurring only due a race condition, I was not able to reproduce the race with the config. I mainly added an additional check and the below config was working as expected.

Vector config used:

data_dir: "/tmp/vector-demo"

# Generate demo syslog-formatted logs every second
sources:
  demo_logs:
    type: demo_logs
    format: syslog
    interval: 1

  internal_metrics:
    type: internal_metrics
    scrape_interval_secs: 5

transforms:
  parse_and_enrich:
    type: remap
    inputs:
      - demo_logs
    source: |
      . = parse_syslog!(string!(.message))
      .service = "vector-demo"

sinks:
  console_logs:
    type: console
    inputs:
      - parse_and_enrich
    encoding:
      codec: json
      json:
        pretty: true

  console_metrics:
    type: console
    inputs:
      - internal_metrics
    encoding:
      codec: json
      json:
        pretty: true 

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details here.

@github-actions github-actions bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@dd-sebastien-lb dd-sebastien-lb force-pushed the sebastien.lubineau/fix-24415 branch 4 times, most recently from 12e30bf to 64d9123 Compare January 9, 2026 17:18
@dd-sebastien-lb
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@dd-sebastien-lb dd-sebastien-lb force-pushed the sebastien.lubineau/fix-24415 branch from 64d9123 to 2cf755b Compare January 12, 2026 08:20
@dd-sebastien-lb dd-sebastien-lb marked this pull request as ready for review January 12, 2026 11:09
@dd-sebastien-lb dd-sebastien-lb requested a review from a team as a code owner January 12, 2026 11:09
Copy link
Member

@bruceg bruceg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@thomasqueirozb thomasqueirozb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasqueirozb thomasqueirozb added this pull request to the merge queue Jan 15, 2026
Merged via the queue into master with commit 46654ad Jan 15, 2026
85 checks passed
@thomasqueirozb thomasqueirozb deleted the sebastien.lubineau/fix-24415 branch January 15, 2026 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic in DatadogMetricsSink: "attempt to subtract with overflow"

3 participants