fix(postgres sink): enable TLS flag#23536
Conversation
|
Hi, do you have any timeline for this merge? It's really an important feature to ensure that postgreSQL is usable in prod scenario |
|
Is there any update regarding this? |
|
Hi all, this PR is blocked because it failed an arm build when building sqlx with I root caused this and it is a failure in rustls not being able to build on ARMv7 with the aws-lc-rs feature flag. I opened an issue (rustls/rustls#2725) and the maintainers quickly and correctly pointed out that aws-lc-rs does cross compile correctly (see comment). This seems to either be a legitimate bug in aws-lc-rs or something wrong with the cross compilation in the current environment (I suspect this is the real issue). I haven't had the time to debug the cross compilation issue further but I did provide a comprehensive example in the rustls issue. Anyone should be able to grab that example and just change the crate from rustls to aws-lc-rs to debug further. If someone knows what is wrong/missing from the cross compilation environment and how to fix it please ping me so I can include the fix in this PR. Maybe related: aws/aws-lc-rs#769 |
|
If someone from the community is interested in picking this up, we can use https://docs.rs/crate/sqlx/0.8.6/features#tls-rustls-ring instead. |
Summary
User reported issue: sqlx wasn't compiled with any TLS feature flags and therefore the Postgres Sink was unable to be used in a TLS enabled environment.
This PR adds
tls-rustls-aws-lc-rstls-rustls-ringfeature to sqlx dependency in (FIPS compliant)Vector configuration
How did you test this PR?
Ran
docker compose up -dVerified SSL was enabled
cargo run -- --config postgres.yamland then verified that the data was indeed there:Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References