feat(azure_logs_ingestion sink): Initial azure_logs_ingestion sink#22912
feat(azure_logs_ingestion sink): Initial azure_logs_ingestion sink#22912pront merged 60 commits intovectordotdev:masterfrom
azure_logs_ingestion sink#22912Conversation
pront
left a comment
There was a problem hiding this comment.
Hi @jlaundry, thanks for this contribution!
It looks good. Two things:
- We will need some documentation files. See an example here (all files under
website). Note thatbase/is generated bymake generate-component-docs. - Is the intention to complete replace the
azure_monitor_logssink? If that's the case maybe we can mark the existing one as deprecated in favor of this new sink.
rtrieu
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Approving with one very minor suggestion.
website/cue/reference/components/sinks/base/azure_logs_ingestion.cue
Outdated
Show resolved
Hide resolved
Apologies, I thought this page was auto-generated as well - added now.
Good point, added 🙂 |
website/cue/reference/components/sinks/base/azure_logs_ingestion.cue
Outdated
Show resolved
Hide resolved
azure_logs_ingestion sinkazure_logs_ingestion sink
From memory, there is a minor refactor required in https://github.com/jlaundry/vector/blob/02562be6447af36404d8b5668434e317c87a45b2/src/sinks/azure_logs_ingestion/config.rs#L139 to change it back to Probably easiest if you rollback the package first, and then I'll rebase, retest, and push. |
|
FYI - Reverted deps #23039 |
|
FYI, I started preparing the rebase, but I've seen that the Azure Rust team have recently decided to change how authentication works with the Depending on what they decide, we may need to explicitly configure credentials, either via the vector config file or environment variables. The So instead of releasing an initial sink, and then requiring another config/environment change, I'll wait until there's stability in the SDK before moving forward with this PR. (I'm not giving up!!!) |
|
Hi @jlaundry, By the way, I see that the discussion here is closed. Does it mean you will go forward with merging your PR? Thanks a lot! |
Makes sense. I feel that these crates are unfortunately a bit unstable and each version update is risky. Thank you for your interest in contributing 👍 |
|
Hi all, currently the |
1720078 to
ffe54be
Compare
|
For those playing along at home (hi @yoelk @Renizmy), a summary of the current issues and why we're blocked:
What I think this means for this PR, and my thoughts/opinions for the wider project:
Also note: The existing |
Hi @jlaundry, I missed the context on this one. How does this break existing users? E.g. assume we keep the |
Signed-off-by: Jed Laundry <jlaundry@jlaundry.com>
Signed-off-by: Jed Laundry <jlaundry@jlaundry.com>
Signed-off-by: Jed Laundry <jlaundry@jlaundry.com>
website/cue/reference/components/sinks/generated/azure_logs_ingestion.cue
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas <thomasqueirozb@gmail.com>
This reverts commit e63f30c.
Signed-off-by: Jed Laundry <jlaundry@jlaundry.com>
Signed-off-by: Jed Laundry <jlaundry@jlaundry.com>
pront
left a comment
There was a problem hiding this comment.
Thank you for the nice work. This is good to go as a new beta component.
|
Very excited for this one. Great job guys! @pront: How would be go about beta testing as intended? |
adf1aba
Summary
The current
azure_monitor_logssink uses the Data Collector API, which has been deprecated and will be removed in September 2026.This sink uses the replacement Logs Ingestion API.
While I did consider making this a drop-in replacement for the existing sink, users need to make numerous breaking infrastructure changes, including:
_CLcustom tables.Change Type
Is this a breaking change?
How did you test this PR?
AZURE_TENANT_ID,AZURE_CLIENT_ID, andAZURE_CLIENT_SECRETenvironment variables from the App Registrationvector.yaml:Does this PR include user facing changes?
References
azure_blob, by using the Azure Identity crate, this sink supports passwordless credentials.