Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enriching): fix flush metrics for memory enrichment table #22296

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

esensar
Copy link
Contributor

@esensar esensar commented Jan 25, 2025

Summary

When flush_interval is not set for memory enrichment table (when data is flushed on every update) flush metrics are not properly updated. This changes that scenario to use the same flushing method, to ensure that object count, size and flush count metrics are properly updated.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR. (Since memory enrichment table is not out yet)

Checklist

  • Please read our Vector contributor resources.
    • make check-all is a good command to run locally. This check is
      defined here. Some of these
      checks might not be relevant to your PR. For Rust changes, at the very least you should run:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Initial memory PR: #21348

When `flush_interval` is not set for `memory` enrichment table (when data is flushed on every
update) flush metrics are not properly updated. This changes that scenario to use the same flushing
method, to ensure that object count, size and flush count metrics are properly updated.
@esensar esensar requested a review from a team as a code owner January 25, 2025 16:24
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and adding more tests @esensar!

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 27, 2025
@pront pront enabled auto-merge January 27, 2025 16:11
@pront
Copy link
Member

pront commented Jan 27, 2025

Since this is an unreleased feature, we won't need a changelog for this PR.

@pront pront added this pull request to the merge queue Jan 27, 2025
Merged via the queue into vectordotdev:master with commit ffd3597 Jan 27, 2025
56 of 58 checks passed
@esensar esensar deleted the fix/memory-flush-metrics branch January 27, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants