chore(ci): Update check-spelling to 0.0.22 by jszwedko · Pull Request #21733 · vectordotdev/vector

jszwedko · 2024-11-07T18:15:14Z

Summary

Updates the check-spelling action to 0.0.22

Change Type

Bug fix
New feature
Non-functional (chore, refactoring, docs)
Performance

Is this a breaking change?

Yes
No

How did you test this PR?

Replaced the trigger with pull_request so that it would run the workflow version from this PR. Successful run: https://github.com/vectordotdev/vector/actions/runs/11730011340/job/32676900007

Does this PR include user facing changes?

Yes. Please add a changelog fragment based on our guidelines.
No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

Please read our Vector contributor resources.
If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Reverts #21732

This reverts commit a0e5b97.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

datadog-vectordotdev · 2024-11-07T18:46:21Z

Datadog Report

Branch report: jszwedko/upgrade-check-spelling
Commit report: ff78532
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.43s Total Time

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko · 2024-11-07T19:17:48Z

.github/workflows/spelling.yml

+      uses: check-spelling/check-spelling@v0.0.22
      with:
-        suppress_push_for_open_pull_request: 1
+        suppress_push_for_open_pull_request: ${{ github.actor != 'dependabot[bot]' && 1 }}


Suggested by https://github.com/check-spelling/check-spelling/releases/tag/v0.0.22

jszwedko · 2024-11-07T19:18:37Z

.github/workflows/spelling.yml

@@ -98,34 +98,39 @@ jobs:
        use_sarif: ${{ (!github.event.pull_request || (github.event.pull_request.head.repo.full_name == github.repository)) && 1 }}
        extra_dictionary_limit: 20
        extra_dictionaries:


v0.0.22 reorganized the cspell dictionaries signficantly as mentioned on https://github.com/check-spelling/check-spelling/releases/tag/v0.0.22 . I updated the list by removing all of them and looking at the suggestions from the check-spell action.

jszwedko · 2024-11-07T19:19:23Z

.github/actions/spelling/expect.txt

@@ -1,5 +1,6 @@
 abcd


cspell dictionaries were changed so I think this resulted in more words needing to be added to the expect.txt. Updated by running the apply.pl suggestion from the check-spelling results.

jszwedko · 2024-11-07T19:26:39Z

website/cue/reference/remap/expressions/path.cue

 					}
 					nonexistent: {
-						title: "Non-existent paths"
+						title: "Nonexistent paths"


Flagged by forbidden patterns.

jszwedko · 2024-11-07T19:39:40Z

The last commit replaces the trigger to pull_request_target, but here is a successful run when I was testing with pull_request: https://github.com/vectordotdev/vector/actions/runs/11730011340/job/32676900007

jszwedko · 2024-11-07T19:42:36Z

pull_request_target will fail since I updated expect.txt in this PR to be compatible with the new version of check-spelling

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

pront

Thank you!

jszwedko · 2024-11-07T20:04:59Z

Merged manually since the required changes to expect.txt were blocking merge when used with 0.0.22 (the version on master).

jszwedko added 2 commits November 7, 2024 10:09

chore(ci): Bump check-spelling/check-spelling from 0.0.21 to 0.0.24

90d2a6f

This reverts commit a0e5b97.

Test upgrade to 0.0.22

4fe3923

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 7, 2024

jszwedko changed the title ~~Jszwedko/upgrade check spelling~~ chore(ci): Update check-spelling to 0.0.24 Nov 7, 2024

Add suggested dictionaries

97afcfb

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko changed the title ~~chore(ci): Update check-spelling to 0.0.24~~ chore(ci): Update check-spelling to 0.0.22 Nov 7, 2024

jszwedko added 2 commits November 7, 2024 10:23

Use suggested condition for suppress_push_for_open_pull_request

be0a785

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

retry

308824b

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko added 5 commits November 7, 2024 11:01

Add more suggested dictionaries

6467484

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

Adding more suggested dictionaries

9b06f70

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

Update expected words

654984f

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

readd spell_check_this

c24fb15

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

Non-existent -> nonexistent

c4bbb41

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Nov 7, 2024

jszwedko added 2 commits November 7, 2024 11:31

Remove entries with warnings from allow.txt

61e4998

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

Replace trigger

22ffabd

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko commented Nov 7, 2024

View reviewed changes

jszwedko marked this pull request as ready for review November 7, 2024 19:39

jszwedko requested review from a team as code owners November 7, 2024 19:39

jszwedko enabled auto-merge November 7, 2024 19:41

Replace check_extra_dictionaries

a196b0c

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>

jszwedko disabled auto-merge November 7, 2024 19:42

pront approved these changes Nov 7, 2024

View reviewed changes

jszwedko merged commit 0527544 into master Nov 7, 2024

jszwedko deleted the jszwedko/upgrade-check-spelling branch November 7, 2024 20:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): Update check-spelling to 0.0.22#21733

chore(ci): Update check-spelling to 0.0.22#21733
jszwedko merged 13 commits intomasterfrom
jszwedko/upgrade-check-spelling

jszwedko commented Nov 7, 2024 •

edited

Loading

Uh oh!

datadog-vectordotdev bot commented Nov 7, 2024 •

edited

Loading

Uh oh!

jszwedko Nov 7, 2024

Uh oh!

jszwedko Nov 7, 2024

Uh oh!

jszwedko Nov 7, 2024

Uh oh!

jszwedko Nov 7, 2024

Uh oh!

jszwedko commented Nov 7, 2024 •

edited

Loading

Uh oh!

jszwedko commented Nov 7, 2024

Uh oh!

pront left a comment

Uh oh!

jszwedko commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jszwedko commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Change Type

Is this a breaking change?

How did you test this PR?

Does this PR include user facing changes?

Checklist

References

Uh oh!

datadog-vectordotdev bot commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

jszwedko Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

jszwedko Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

jszwedko Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

jszwedko Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

jszwedko commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jszwedko commented Nov 7, 2024

Uh oh!

pront left a comment

Choose a reason for hiding this comment

Uh oh!

jszwedko commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jszwedko commented Nov 7, 2024 •

edited

Loading

datadog-vectordotdev bot commented Nov 7, 2024 •

edited

Loading

jszwedko commented Nov 7, 2024 •

edited

Loading