-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(new sink): Add possibility to use nats jetstream in nats sink #20834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
b2d1f5a
30de051
3209e57
11afa3f
ce4e8c2
86b9956
56cf844
0721bf5
dca5a3f
7eeeb52
7189c7f
602ba0d
0188122
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| Add possibility to use NATS JetStream in NATS sink. Can be turned on/off via `jetstream` option (default is false). | ||
|
|
||
| ### Example | ||
|
|
||
| #### Config | ||
|
|
||
| ``` | ||
| sinks: | ||
| nats: | ||
| type: nats | ||
| inputs: | ||
| - in | ||
| subject: nork | ||
| url: "nats://localhost:4222" | ||
| jetstream: true | ||
| encoding: | ||
| codec: json | ||
| ``` | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -383,6 +383,17 @@ base: components: sinks: nats: configuration: { | |||||
| } | ||||||
| } | ||||||
| } | ||||||
| jetstream: { | ||||||
| description: """ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
actually these should be removed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file has been generated from the doc comments added in the code, so it won't be possible to remove these quotes. They are a part of |
||||||
| Send messages using [Jetstream][jetstream]. | ||||||
|
|
||||||
| If set, the `subject` must belong to an existing JetStream stream. | ||||||
|
|
||||||
| [jetstream]: https://docs.nats.io/nats-concepts/jetstream | ||||||
| """ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| required: false | ||||||
| type: bool: default: false | ||||||
| } | ||||||
| request: { | ||||||
| description: """ | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| Middleware settings for outbound requests. | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog should be fairly succinct, so we don't need the example here. We do need the authors included for external contributors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you make sure it ends with a newline please.