Conversation
…for `datadog_logs` sink
It would be even better if we had a corresponding JIRA issue since it is very easy to forget such things. |
One exists already and is assigned to me, I wasn't mentioning it here since it's a source of divide with the community. |
|
Note- I'm holding off on this PR until #19927 is merged into master. It will nullify the need to increase the static sleep (because it's removed) and it also changes the error validation case (which this branch currently is missing and it makes more sense to add only once). |
datadog_logs sinkdatadog_logs sink
Datadog ReportBranch report: ✅ 0 Failed, 43 Passed, 0 Skipped, 1m 30.09s Wall Time |
Regression Detector ResultsRun ID: e983c921-4543-4cd4-b653-6628f74b292f Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | socket_to_socket_blackhole | ingress throughput | +3.58 | [+3.51, +3.65] |
| ➖ | otlp_http_to_blackhole | ingress throughput | +2.68 | [+2.52, +2.84] |
| ➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +1.74 | [+1.64, +1.85] |
| ➖ | datadog_agent_remap_datadog_logs | ingress throughput | +0.98 | [+0.87, +1.09] |
| ➖ | datadog_agent_remap_blackhole | ingress throughput | +0.56 | [+0.46, +0.65] |
| ➖ | fluent_elasticsearch | ingress throughput | +0.52 | [+0.06, +0.99] |
| ➖ | http_to_s3 | ingress throughput | +0.20 | [-0.09, +0.48] |
| ➖ | http_to_http_noack | ingress throughput | +0.12 | [+0.04, +0.20] |
| ➖ | http_elasticsearch | ingress throughput | +0.09 | [+0.01, +0.16] |
| ➖ | http_to_http_json | ingress throughput | +0.03 | [-0.04, +0.11] |
| ➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.00 | [-0.13, +0.14] |
| ➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.15, +0.15] |
| ➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.04 | [-0.16, +0.07] |
| ➖ | enterprise_http_to_http | ingress throughput | -0.09 | [-0.16, -0.03] |
| ➖ | http_to_http_acks | ingress throughput | -0.10 | [-1.41, +1.20] |
| ➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.26 | [-0.38, -0.13] |
| ➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -0.45 | [-0.54, -0.37] |
| ➖ | http_text_to_http_json | ingress throughput | -0.48 | [-0.60, -0.35] |
| ➖ | otlp_grpc_to_blackhole | ingress throughput | -0.48 | [-0.56, -0.39] |
| ➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.65 | [-0.76, -0.54] |
| ➖ | splunk_hec_route_s3 | ingress throughput | -0.92 | [-1.41, -0.42] |
| ➖ | syslog_loki | ingress throughput | -0.95 | [-0.99, -0.91] |
| ➖ | syslog_splunk_hec_logs | ingress throughput | -1.46 | [-1.53, -1.39] |
| ➖ | file_to_blackhole | egress throughput | -1.75 | [-4.21, +0.71] |
| ➖ | syslog_humio_logs | ingress throughput | -2.22 | [-2.30, -2.13] |
| ➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -3.16 | [-3.31, -3.01] |
| ➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -3.38 | [-3.51, -3.25] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Regression Detector ResultsRun ID: 7d70ccb9-df38-431b-ac09-9f8afdba2d00 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI |
|---|---|---|---|---|
| ➖ | http_text_to_http_json | ingress throughput | +3.30 | [+3.17, +3.44] |
| ➖ | otlp_http_to_blackhole | ingress throughput | +2.45 | [+2.29, +2.61] |
| ➖ | datadog_agent_remap_blackhole | ingress throughput | +2.15 | [+2.04, +2.26] |
| ➖ | syslog_splunk_hec_logs | ingress throughput | +1.49 | [+1.42, +1.55] |
| ➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | +1.47 | [+1.33, +1.61] |
| ➖ | socket_to_socket_blackhole | ingress throughput | +1.11 | [+1.04, +1.17] |
| ➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +1.00 | [+0.92, +1.08] |
| ➖ | datadog_agent_remap_blackhole_acks | ingress throughput | +0.33 | [+0.24, +0.42] |
| ➖ | syslog_log2metric_humio_metrics | ingress throughput | +0.32 | [+0.18, +0.47] |
| ➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.16 | [+0.02, +0.29] |
| ➖ | http_to_http_noack | ingress throughput | +0.14 | [+0.05, +0.23] |
| ➖ | http_to_http_acks | ingress throughput | +0.10 | [-1.21, +1.42] |
| ➖ | http_to_http_json | ingress throughput | +0.07 | [-0.01, +0.15] |
| ➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.15, +0.15] |
| ➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.01 | [-0.14, +0.13] |
| ➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.03 | [-0.14, +0.09] |
| ➖ | splunk_hec_route_s3 | ingress throughput | -0.07 | [-0.59, +0.45] |
| ➖ | enterprise_http_to_http | ingress throughput | -0.12 | [-0.20, -0.04] |
| ➖ | otlp_grpc_to_blackhole | ingress throughput | -0.25 | [-0.33, -0.17] |
| ➖ | fluent_elasticsearch | ingress throughput | -0.33 | [-0.80, +0.14] |
| ➖ | http_to_s3 | ingress throughput | -0.39 | [-0.67, -0.11] |
| ➖ | syslog_humio_logs | ingress throughput | -0.39 | [-0.51, -0.28] |
| ➖ | datadog_agent_remap_datadog_logs | ingress throughput | -0.47 | [-0.58, -0.36] |
| ➖ | http_elasticsearch | ingress throughput | -0.47 | [-0.54, -0.40] |
| ➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -0.50 | [-0.61, -0.38] |
| ➖ | syslog_loki | ingress throughput | -1.82 | [-1.89, -1.74] |
| ➖ | file_to_blackhole | egress throughput | -2.07 | [-4.46, +0.32] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…g_logs` sink (vectordotdev#19887) * chore(observability): add happy path component spec validation tests for `datadog_logs` sink * add sad path case
Adding the sad path cases is blocked by #18062