fix(loki sink): update to use the global list of compression algorithms#19104
Merged
StephenWakely merged 3 commits intoopw/releases/v1.7from Nov 9, 2023
Merged
fix(loki sink): update to use the global list of compression algorithms#19104StephenWakely merged 3 commits intoopw/releases/v1.7from
StephenWakely merged 3 commits intoopw/releases/v1.7from
Conversation
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
github-actions
bot
added
domain: sinks
pront
approved these changes
Nov 9, 2023
Datadog ReportBranch report: ✅ |
dsmith3197
reviewed
Nov 9, 2023
Comment on lines
+94
to
100
| if self.compression == Compression::Snappy { | ||
| // Snappy compression is applied after converting the batch to protobuf so | ||
| // we need to handle this separately. | ||
| Compression::None | ||
| } else { | ||
| self.compression | ||
| } |
Contributor
There was a problem hiding this comment.
Does it make more sense to remove the snap encoding here and defer to the request builder here?
Contributor
Author
There was a problem hiding this comment.
Hmm.. potentially. I'll look into that for merging into master.
neuronull
pushed a commit
that referenced
this pull request
Nov 16, 2023
…ms (#19104) * Update to use the global list of compression algorithms Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Mention snappy compression using protocol buffers Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> * Snappy is compressed separately Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com> --------- Signed-off-by: Stephen Wakely <fungus.humungus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Loki sink had some special code to handle snappy. snappy was #18676 to the global list of compression schemes. This meant Loki was specifying snappy twice. It looks like this broke the schema validation.
This PR removes the special config option for snappy, but hopefully still handles the choice of snappy differently (encodes it as protobuf), as it did before.