Skip to content

chore(observability): deprecate obsolete http metrics #18972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsmith3197 merged 9 commits into from
Nov 3, 2023
Merged

chore(observability): deprecate obsolete http metrics #18972

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2e7322e
OPW-94 deprecate obsolete http metrics
dsmith3197 Oct 27, 2023
a471c59
feedback
dsmith3197 Oct 30, 2023
e8c5079
feedback
dsmith3197 Oct 30, 2023
8c1213f
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Oct 30, 2023
fb2f173
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Oct 31, 2023
bfab421
fmt
dsmith3197 Oct 31, 2023
d63574b
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Nov 1, 2023
63484d4
Update DEPRECATIONS.md
dsmith3197 Nov 1, 2023
aada1ea
Merge branch 'master' into dougsmith/deprecate-old-http-metrics
dsmith3197 Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/DEPRECATIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ See [DEPRECATION.md](docs/DEPRECATION.md#process) for the process for updating t

## To be removed

### 0.34.0
* Support for `v1` series endpoint in the `datadog_metrics` sink should be removed.
* legacy_openssl_provider v0.34.0 OpenSSL legacy provider flag should be removed
* armv7_rpm v0.34.0 The armv7 RPM packages should be removed (replaced by armv7hl)

### 0.35.0
* `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics
15 changes: 15 additions & 0 deletions website/content/en/highlights/2023-11-07-0-34-0-upgrade-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Vector's 0.34.0 release includes **breaking changes**:
1. [Removal of `peer_addr` Metric Tag](#remove-peer-addr)
1. [Blackhole sink no longer reports by default](#blackhole-sink-reporting)

and **deprecations**:

1. [Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics](#deprecate-obsolete-http-metrics)

We cover them below to help you upgrade quickly:

Expand Down Expand Up @@ -91,3 +94,15 @@ The `peer_addr` tag has been removed from the `component_received_bytes_total` i
The `blackhole` sink no longer reports events processed every second by default. Instead this
behavior can be opted into by setting `print_interval_secs` to `1` (or any other integer). This
change was made due to users being surprised that this sink generates output by default.

### Deprecations

#### Deprecation of `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` Internal Metrics {#deprecate-obsolete-http-metrics}

The `requests_completed_total`, `request_duration_seconds`, and `requests_received_total` internal metrics are removed in the 0.35.0 release.

| Deprecated metric | Replacement metric | Affected components |
|-----------------------------|-------------------------------------|------------------------------------------------------------------------------------------|
| requests_completed_total | http_client_responses_total | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| request_duration_seconds | http_client_response_rtt_seconds | apache metrics, aws ecs metrics, http client, prometheus remote write, prometheus scrape |
| requests_received_total | http_server_requests_received_total | aws kinesis firehose, heroku logplex, prometheus exporter, splunk hec |