Skip to content

chore(ci): Bump check-spelling/check-spelling from 0.0.21 to 0.0.22#18751

Closed
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/github_actions/check-spelling/check-spelling-0.0.22
Closed

chore(ci): Bump check-spelling/check-spelling from 0.0.21 to 0.0.22#18751
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/github_actions/check-spelling/check-spelling-0.0.22

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 3, 2023

Bumps check-spelling/check-spelling from 0.0.21 to 0.0.22.

Release notes

Sourced from check-spelling/check-spelling's releases.

Release 0.0.22

⏩ Upgrading

  • 🏷️ Test first on a branch by changing your workflow tags/references to this release. See 🐣 Breaking Changes for how to adapt your workflow.

Going forward, if you have suppress_push_for_open_pull_request: 1 in your workflow, you should probably change it to suppress_push_for_open_pull_request: ${{ github.actor != 'dependabot[bot]' && 1 }} see Suppress PR check when workflow changes .

🐣 Breaking Changes

🗜️ Reorganized cspell Dictionaries

cspell: dictionaries have been reorganized.

Background

There are 3 related configuration items:

  • dictionary_source_prefixes
    • In v0.0.21, this had: "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20220816/dictionaries/"
    • In v0.0.22, it has: "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/"
  • extra_dictionaries
  • check_extra_dictionaries
    • The list has changed between v0.0.21 and v0.0.22, a bunch have moved, some have split, and a bunch have been added.

Migrating

You can migrate in a couple of ways:

  • Assuming you haven't set dictionary_source_prefixes, you can temporarily clear extra_dictionaries and check_extra_dictionaries and then use one run to get a new set of recommended extra_dictionaries and then set check_extra_dictionaries (typically to '').
  • If you want to keep your current cspell extra_dictionaries, change cspell to cspell_old (or anything that isn't cspell) and set dictionary_source_prefixes to something like this: {"cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20220816/dictionaries/", "cspell_old": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20220427/dictionaries/"}.

Note that the main branch for check-spelling/cspell-dicts will move (roughly at the time of the v0.0.22 release and again for future releases).

Dropping printf special cases

Background

check-spelling has evolved from a very simple script that included some special handling for \r/\t/\n because it was originally developed to focus on C++ and similar files. Over time, check-spelling has been used on many repositories where these patterns can appear in contexts where they aren't C style escapes, and thus it has outgrown this assumption.

Migrating

You can copy the code from: https://github.com/check-spelling/spell-check-this/blob/b968ca32e0e5961a85c7fe3e9431f81553c3f434/.github/actions/spelling/candidate.patterns#L591-L595 into candidate.patterns and consider one of those patterns is the appropriate pattern to include in your configuration.

If you have workarounds for the old behavior, you should be able to remove them.

💔 Dropping support for broken act

Background

nektos/act is an alternate implementation of the GitHub Actions api environment. Each of check-spelling, GHA, and act have bugs and evolve at different rates (check-spelling releases on by far the slowest cycle). check-spelling had some workarounds for quirks of act from a long time ago and those interacted badly with newer GHA behaviors. In order to simplify life, support for some of those quirks has been removed.

... (truncated)

Commits
  • 00c989c Release 0.0.22
  • ba06773 Restructure README
  • b8a543f Upgrade to checkout@v4
  • 3b11c85 Tolerate more apostrophes
  • 697744a Report HTTP response code for dictionary-not-found
  • 596ae6b Provide importable commit in report
  • 280403b Use ':rotating_light: alerts' for code scanning results
  • 5ca992f Clarify that you do not have to use these commands
  • 676e503 Fix sarif detection
  • bfebcb1 Harmonize report paths
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the domain: ci Anything related to Vector's CI environment label Oct 3, 2023
@bits-bot
Copy link

bits-bot commented Oct 3, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit db28ad2
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/651c52f13730fd000838a121
😎 Deploy Preview https://deploy-preview-18751--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit db28ad2
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/651c52f1f48d630007073e74

@github-actions github-actions bot removed the domain: ci Anything related to Vector's CI environment label Oct 3, 2023
@jszwedko
Copy link
Collaborator

jszwedko commented Oct 3, 2023

This is a breaking change that we'll need to adjust for.

@neuronull neuronull added meta: blocked Anything that is blocked to the point where it cannot be worked on. and removed meta: blocked Anything that is blocked to the point where it cannot be worked on. labels Oct 16, 2023
@neuronull neuronull added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 8, 2024
@neuronull
Copy link
Contributor

@dependabot rebase

Bumps [check-spelling/check-spelling](https://github.com/check-spelling/check-spelling) from 0.0.21 to 0.0.22.
- [Release notes](https://github.com/check-spelling/check-spelling/releases)
- [Commits](check-spelling/check-spelling@v0.0.21...v0.0.22)

---
updated-dependencies:
- dependency-name: check-spelling/check-spelling
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/check-spelling/check-spelling-0.0.22 branch from db28ad2 to 9db2a8e Compare January 8, 2024 18:56
@jszwedko jszwedko requested a review from a team as a code owner October 3, 2024 18:54
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 1, 2024

Superseded by #21678.

@dependabot dependabot bot closed this Nov 1, 2024
@dependabot dependabot bot deleted the dependabot/github_actions/check-spelling/check-spelling-0.0.22 branch November 1, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants