-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat(metrics): support Datadog metric origin metadata #18405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,802
−1,128
Merged
Changes from 19 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
56443fd
add the new origin metadata to the EventMetadata
neuronull 93fa1fa
set OriginService in log_to_metric transform
neuronull 46850c9
decode unknown protobuf fields with protofish
neuronull b2f97ec
experiment with parsing the Origin metadata field by specifying in th…
neuronull cc7b317
start adding the metadata to the series in dd metrics sink
neuronull 6914fa9
add logic for setting the non-pass through metadata in dd metrics sink
neuronull 01e170a
add tests, implement for sketches
neuronull 6c1f388
touch up
neuronull c95cefc
cleanup
neuronull 7122f29
doc
neuronull 7953d8c
typo
neuronull 4ea935d
fix transform unit tests
neuronull 319ec8d
check events
neuronull a4d721c
remove internal/deprecated fields
neuronull cc163f6
docs
neuronull 1ca2f9d
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull a912fe5
feedback ds: static str
neuronull a24ebe4
feedback ds and js
neuronull 5df328e
delete
neuronull d4de720
review feedback
neuronull 9761139
pass origin metadata in vector proto
neuronull 0e3d2b6
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull 0167110
fix issue with native codec unit test. add breaking change deprecatio…
neuronull 1236503
check fmt/markdown
neuronull e46319b
restore json
neuronull b64f5b0
Revert "restore json"
neuronull b4190b2
make metric series proto backwards compatible
neuronull 332d5b6
comment out test for functionality that is broken
neuronull a1d1016
check events
neuronull e91754b
update patch files
neuronull 3d5696d
Revert "make metric series proto backwards compatible"
neuronull a49391e
Merge branch 'master' into neuronull/feat_metrics_origin
neuronull 900464c
add the GH issue to the TODO
neuronull 9cf0847
whitespace in proto
neuronull f591d76
gitattribute
dsmith3197 60aacfa
feedback
dsmith3197 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,17 @@ message CommonMetadata { | |
| string api_key = 6; | ||
| } | ||
|
|
||
| message Origin { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note to reviewers: This was a change to prove this approach will work for Vector. Currently the official public proto file does not contain these additions. But hopefully will soon. |
||
| reserved 1,2,3; | ||
| uint32 origin_product = 4; | ||
| uint32 origin_category = 5; | ||
| uint32 origin_service = 6; | ||
| } | ||
|
|
||
| message Metadata { | ||
| Origin origin = 1; | ||
| } | ||
|
|
||
| message MetricPayload { | ||
| enum MetricType { | ||
| UNSPECIFIED = 0; | ||
|
|
@@ -40,7 +51,7 @@ message MetricPayload { | |
| string unit = 6; | ||
| string source_type_name = 7; | ||
| int64 interval = 8; | ||
| reserved 9; | ||
| Metadata metadata = 9; | ||
|
neuronull marked this conversation as resolved.
|
||
| } | ||
| repeated MetricSeries series = 1; | ||
| } | ||
|
|
@@ -76,6 +87,7 @@ message SketchPayload { | |
| reserved 5, 6; | ||
| reserved "distributionsK", "distributionsC"; | ||
| repeated Dogsketch dogsketches = 7; | ||
| Metadata metadata = 8; | ||
| } | ||
| repeated Sketch sketches = 1; | ||
| CommonMetadata metadata = 2; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.