fix(dev): Unfeature flag internal_events::parser#18322
fix(dev): Unfeature flag internal_events::parser#18322
Conversation
Was overeargerly flagged in #18308 which caused CI failures in the nightly Component Features workflow. See: https://github.com/vectordotdev/vector/actions/runs/5908210923/attempts/1 Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vrl-playground canceled.
|
Datadog ReportBranch report: ✅ |
|
Ah, I saw now in the description of this PR which features failed. Anyway, I think the correct thing to do is not to unflag, but to flag the other components too to clearly represent the actual dependency of these components to the parser module. As I mentioned in the other PR, when compiling Vector with minimal flags, and the parser is not flagged, it will complain that there is unused code (the parser). EDIT: The output of the actions job you linked is very useful to do this correctly actually. After this fixing PR is merged, I can work out better the feature flag dependencies 👍. I didn't know of EDIT2: And apologies for breaking this 🙈. |
|
Replaced by #18327 |
That CI check only runs nightly because it is expensive and doesn't break very often. I should have thought to manually trigger it on your PR modifying feature flags though 😅 |
No worries! Normally CI would catch things like this. |
Ah that sounds like good insight to be careful running it locally :) |
3 participants
Was overeargerly flagged in #18308 which caused CI
failures in the nightly Component Features workflow.
See: https://github.com/vectordotdev/vector/actions/runs/5908210923/attempts/1
Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com