-
Notifications
You must be signed in to change notification settings - Fork 2k
enhancement(core): Add CLI arg and env variable to control openssl probing #18229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dsmith3197
merged 4 commits into
vectordotdev:master
from
hhromic:enh-openssl-probe-vars
Aug 15, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5d8719c
enhancement(core): Add CLI arg and env variable to control openssl pr…
hhromic f2c8028
Document new option and env variable
hhromic 86ae963
Remove copy/pasted block by mistake
hhromic 8edb011
Align in-code comment with reference documentation
hhromic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -113,6 +113,14 @@ cli: { | |
| description: env_vars.VECTOR_NO_GRACEFUL_SHUTDOWN_LIMIT.description | ||
| env_var: "VECTOR_NO_GRACEFUL_SHUTDOWN_LIMIT" | ||
| } | ||
| "openssl-legacy-provider": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for adding this one too :) |
||
| description: env_vars.VECTOR_OPENSSL_LEGACY_PROVIDER.description | ||
| env_var: "VECTOR_OPENSSL_LEGACY_PROVIDER" | ||
| } | ||
| "openssl-no-probe": { | ||
| description: env_vars.VECTOR_OPENSSL_NO_PROBE.description | ||
| env_var: "VECTOR_OPENSSL_NO_PROBE" | ||
| } | ||
| } | ||
|
|
||
| _core_config_options: { | ||
|
|
@@ -624,6 +632,18 @@ cli: { | |
| description: "Never time out while waiting for graceful shutdown after SIGINT or SIGTERM received. This is useful when you would like for Vector to attempt to send data until terminated by a SIGKILL. Overrides/cannot be set with `--graceful-shutdown-limit-secs`." | ||
| type: bool: default: false | ||
| } | ||
| VECTOR_OPENSSL_LEGACY_PROVIDER: { | ||
| description: "Load the OpenSSL legacy provider." | ||
| type: bool: default: true | ||
| } | ||
| VECTOR_OPENSSL_NO_PROBE: { | ||
| description: """ | ||
| Disable probing and configuration of root certificate locations on the system for OpenSSL. | ||
|
|
||
| The probe functionality manipulates the `SSL_CERT_FILE` and `SSL_CERT_DIR` environment variables in the Vector process. This behavior can be problematic for users of the `exec` source, which by default inherits the environment of the Vector process. | ||
| """ | ||
| type: bool: default: false | ||
| } | ||
| } | ||
|
|
||
| // Helpers | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.