Skip to content

feat: panic if the condition return type is not a boolean #18196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pront merged 2 commits into from
Aug 9, 2023
Merged

feat: panic if the condition return type is not a boolean #18196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d2ca11
feat: emit an error if the condition return type is not a boolean
pront Aug 9, 2023
18766ae
panic instead of just emit
pront Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/conditions/vrl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,12 @@ impl Conditional for Vrl {
let result = result
.map(|value| match value {
Value::Boolean(boolean) => boolean,
_ => false,
_ => {
emit!(VrlConditionExecutionError {
error: "VRL condition did not return a boolean type"
});
false
}
})
.unwrap_or_else(|err| {
emit!(VrlConditionExecutionError {
Expand Down