Skip to content

feat(component validation): validate component_discarded_events_total for sources #17981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neuronull wants to merge 4 commits into from
Closed

feat(component validation): validate component_discarded_events_total for sources #17981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
682d9a8
add discarded events validator for sources
neuronull Jul 13, 2023
abdf34b
update comment
neuronull Jul 14, 2023
83141cc
Merge branch 'neuronull/draft_component_validation_better_validation'…
neuronull Jul 19, 2023
587a094
feedback tz
neuronull Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/validation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ pub struct RunnerMetrics {
pub sent_bytes_total: u64, // a reciprocal for received_bytes_total
pub sent_event_bytes_total: u64,
pub sent_events_total: u64,
pub discarded_events_total: u64,
}

#[cfg(all(test, feature = "component-validation-tests"))]
Expand Down
16 changes: 16 additions & 0 deletions src/components/validation/validators/component_spec/sources.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ pub enum SourceMetricType {
ReceivedBytesTotal,
SentEventsTotal,
SentEventBytesTotal,
EventsDiscardedTotal,
}

impl SourceMetricType {
Expand All @@ -24,6 +25,7 @@ impl SourceMetricType {
SourceMetricType::ReceivedBytesTotal => "component_received_bytes_total",
SourceMetricType::SentEventsTotal => "component_sent_events_total",
SourceMetricType::SentEventBytesTotal => "component_sent_event_bytes_total",
SourceMetricType::EventsDiscardedTotal => "component_discarded_events_total",
}
}
}
Expand All @@ -47,6 +49,7 @@ pub fn validate_sources(
validate_component_received_bytes_total,
validate_component_sent_events_total,
validate_component_sent_event_bytes_total,
validate_component_discarded_events_total,
];

for v in validations.iter() {
Expand Down Expand Up @@ -226,3 +229,16 @@ fn validate_component_sent_event_bytes_total(
expected_bytes,
)
}

fn validate_component_discarded_events_total(
telemetry_events: &[Event],
runner_metrics: &RunnerMetrics,
) -> Result<Vec<String>, Vec<String>> {
let expected_dropped = runner_metrics.discarded_events_total;
Copy link
Contributor Author

@neuronull neuronull Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note- the expected value is not currently being set.

This is a rather tricky one to validate since it requires forcing the stream to close, after we sent the events to the source and before it sent them to the downstream.


validate_events_total(
telemetry_events,
&SourceMetricType::EventsDiscardedTotal,
expected_dropped,
)
}