Skip to content

chore(ci): fix comment author validation #17794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jszwedko merged 2 commits into from
Jun 29, 2023
Merged

chore(ci): fix comment author validation #17794

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
686b049
chore(ci): fix comment author validation
neuronull Jun 28, 2023
5d353e5
feeback ds: simplify
neuronull Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/comment-trigger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,24 @@ jobs:
|| contains(github.event.comment.body, '/ci-run-regression')
)
steps:
- name: Validate issue comment
- name: Get PR comment author
id: comment
uses: tspascoal/get-user-teams-membership@v2
with:
username: ${{ github.actor }}
team: 'Vector'
GITHUB_TOKEN: ${{ secrets.GH_PAT_ORG }}

- name: Validate author membership
env:
isTeamMember: ${{ steps.comment.outputs.isTeamMember }}
run: |
if [ "${{ steps.comment.outputs.isTeamMember }}" = "false" ] ; then
exit 1
else
exit 0
fi
Comment thread
neuronull marked this conversation as resolved.
Outdated

cli:
needs: validate
if: contains(github.event.comment.body, '/ci-run-all') || contains(github.event.comment.body, '/ci-run-cli')
Expand Down
7 changes: 0 additions & 7 deletions .github/workflows/cross.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,6 @@ jobs:
needs: cross-linux
if: needs.cross-linux.result == 'success' && github.event_name == 'issue_comment'
steps:
- name: Validate issue comment
uses: tspascoal/get-user-teams-membership@v2
with:
username: ${{ github.actor }}
team: 'Vector'
GITHUB_TOKEN: ${{ secrets.GH_PAT_ORG }}

- name: (PR comment) Get PR branch
uses: xt0rted/pull-request-comment-branch@v2
id: comment-branch
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/integration-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,24 @@ jobs:
runs-on: ubuntu-latest
if: contains(github.event.comment.body, '/ci-run-integration') || contains(github.event.comment.body, '/ci-run-all')
steps:
- name: Validate issue comment
if: github.event_name == 'issue_comment'
- name: Get PR comment author
id: comment
uses: tspascoal/get-user-teams-membership@v2
with:
username: ${{ github.actor }}
team: 'Vector'
GITHUB_TOKEN: ${{ secrets.GH_PAT_ORG }}

- name: Validate author membership
env:
isTeamMember: ${{ steps.comment.outputs.isTeamMember }}
run: |
if [ "${{ steps.comment.outputs.isTeamMember }}" = "false" ] ; then
exit 1
else
exit 0
fi

- name: (PR comment) Get PR branch
uses: xt0rted/pull-request-comment-branch@v2
id: comment-branch
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/unit_windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,6 @@ jobs:
test-windows:
runs-on: [windows, windows-2019-8core]
steps:
- name: Validate issue comment
if: github.event_name == 'issue_comment'
uses: tspascoal/get-user-teams-membership@v2
with:
username: ${{ github.actor }}
team: 'Vector'
GITHUB_TOKEN: ${{ secrets.GH_PAT_ORG }}

- name: (PR comment) Get PR branch
if: ${{ github.event_name == 'issue_comment' }}
uses: xt0rted/pull-request-comment-branch@v2
Expand Down