Skip to content

chore(ci): fix failure notify job conditional in publish workflow #17468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neuronull merged 1 commit into from
May 23, 2023
Merged

chore(ci): fix failure notify job conditional in publish workflow #17468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,7 @@ jobs:
publish-github:
name: Publish to GitHub
# We only publish to GitHub for versioned releases, not nightlies.
if: ${{ inputs.channel == 'release' }}
if: inputs.channel == 'release'
runs-on: ubuntu-20.04
needs:
- generate-publish-metadata
Expand Down Expand Up @@ -618,7 +618,7 @@ jobs:
publish-homebrew:
name: Publish to Homebrew
# We only publish to Homebrew for versioned releases, not nightlies.
if: ${{ inputs.channel == 'release' }}
if: inputs.channel == 'release'
runs-on: ubuntu-20.04
needs:
- generate-publish-metadata
Expand All @@ -638,7 +638,7 @@ jobs:
publish-cloudsmith:
name: Publish to Cloudsmith
# We only publish to CloudSmith for versioned releases, not nightlies.
if: ${{ inputs.channel == 'release' }}
if: inputs.channel == 'release'
runs-on: ubuntu-20.04
needs:
- generate-publish-metadata
Expand Down Expand Up @@ -751,7 +751,7 @@ jobs:

publish-failure:
name: Send Publish Failure Notification
if: ${{ inputs.channel != 'custom' }} && failure()
if: failure() && inputs.channel != 'custom'
runs-on: ubuntu-20.04
needs:
- generate-publish-metadata
Expand Down