chore(ci): restrict k8s workflow runs#17416
chore(ci): restrict k8s workflow runs#17416neuronull merged 4 commits intoneuronull/ci_add_merge_queuefrom
Conversation
jszwedko
left a comment
There was a problem hiding this comment.
One question about how we'll keep abreast of failures, otherwise 👍
| schedule: | ||
| # At midnight UTC Tue-Sat | ||
| - cron: '0 0 * * 2-6' |
There was a problem hiding this comment.
How will we be notified if the scheduled build fails? I just want to make sure it doesn't slip through the cracks. Maybe we could take this opportunity to setup a Slack notification?
There was a problem hiding this comment.
👀 Datadog Monitor 👀
There was a problem hiding this comment.
Doh, yeah that's kinda important lol.
I'll take a look at adding a Datadog Monitor.
There was a problem hiding this comment.
In addition to looking at Datadog Monitors, I'd also evaluate https://github.blog/changelog/2022-12-06-github-actions-workflow-notifications-in-slack-and-microsoft-teams/ .
There was a problem hiding this comment.
After some research and discussion, we will try the GHA workflow notifications in slack first and pivot if needed.
There aren't any edits needed to the workflow file itself for that.
Regression Detector ResultsRun ID: 4b17c11a-6c2b-4901-b9a7-347cee86b2a8 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
Regression Detector ResultsRun ID: 41f024e3-9e8e-47e1-ad25-282098181021 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
Restricts the running of k8s tests.
We now run all versions once nightly on weeknights.
Otherwise, run only the latest version.
To track the workflow, we will setup the slack GH App to subscribe to the workflow.