chore(ci): Move the Regression tests to merge queue, unify as one workflow#17399
Merged
neuronull merged 11 commits intoneuronull/ci_add_merge_queuefrom May 19, 2023
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/regression.yml
Outdated
| - name: Setup PR metadata | ||
| id: pr-metadata | ||
| # If triggered by issue comment, the event payload doesn't directly contain the head and base sha from the PR. | ||
| # But, we can retreive this info from some commands. |
Check failure
Code scanning / check-spelling
Unrecognized Spelling
github-actions
bot
removed
the
domain: ci
10 tasks
jszwedko
reviewed
May 16, 2023
Collaborator
jszwedko
left a comment
jszwedko
left a comment
There was a problem hiding this comment.
Just a couple of questions, otherwise looks good to me! Thanks for adding the comments.
blt
approved these changes
May 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are complications in running workflows triggered from another workflow run (as in the case of the current trusted regression workflow), when that is performed within the context of a merge queue. This is further made challenging by the fact that merge queues require the same status checks as pull requests (for now).
To resolve this, the regression tests were combined into a singular workflow.
The reason they were split was as a security measure, to prevent actions from being taken within a privileged context.
To maintain the security in the combined workflow, this is implicitly handled by the workflow triggers:
The regression report still uploads to the PR as previously, regardless of the trigger method.
If the regression experiment fails in a merge queue run, the PR is ejected from the merge queue.