-
Notifications
You must be signed in to change notification settings - Fork 2k
chore(deps): Add 3rd party license file and CI checks #17344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
06e4970
chore(deps): Add 3rd party license file and CI checks
bruceg 841659f
Skip running the 3rd-party license check on deny changes
bruceg 4ed9041
Add comments on the external crate license overrides
bruceg c80773c
fixup license file, not sure why it was broken
bruceg 65d42fb
Move installation of license tool to the environment prepare script
bruceg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| [overrides] | ||
| "backon" = { origin = "https://github.com/Xuanwo/backon" } | ||
| "bollard-stubs" = { origin = "https://github.com/fussybeaver/bollard" } | ||
| "openssl-macros" = { origin = "https://github.com/sfackler/rust-openssl" } | ||
| "serde_nanos" = { origin = "https://github.com/caspervonb/serde_nanos" } | ||
|
|
||
| # These can go away once Vector starts using a release of the VRL crate with a | ||
| # library field set up. | ||
| "vrl" = { license = "MPL-2.0" } | ||
| "vrl-compiler" = { license = "MPL-2.0" } | ||
| "vrl-core" = { license = "MPL-2.0" } | ||
| "vrl-diagnostic" = { license = "MPL-2.0" } | ||
| "vrl-parser" = { license = "MPL-2.0" } | ||
| "vrl-tests" = { license = "MPL-2.0" } | ||
|
|
||
| # `ring` has a custom license that is mostly "ISC-style" but parts of it also fall under OpenSSL licensing. | ||
| "ring-0.16.20" = { license = "ISC AND Custom" } | ||
|
|
||
| # `rustls-webpki` doesn't specify their license in the metadata, but the file contains the ISC terms. | ||
| "rustls-webpki-0.100.1" = { license = "ISC" } | ||
|
|
||
| # `webpki` doesn't specify their license in the metadata, but the file contains the ISC terms. | ||
| "webpki-0.21.4" = { license = "ISC" } | ||
| "webpki-0.22.0" = { license = "ISC" } | ||
|
|
||
| # `zerocopy` et al don't specify their licenses in the metadata, but the file contains the 2-clause BSD terms. | ||
| "zerocopy-0.6.1" = { license = "BSD-2-Clause" } | ||
| "zerocopy-derive-0.3.2" = { license = "BSD-2-Clause" } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| use anyhow::Result; | ||
|
|
||
| use crate::app; | ||
|
|
||
| /// Rebuild the 3rd-party license file. | ||
| #[derive(clap::Args, Debug)] | ||
| #[command()] | ||
| pub struct Cli {} | ||
|
|
||
| impl Cli { | ||
| pub fn exec(self) -> Result<()> { | ||
| app::exec("rust-license-tool", ["write"], true) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| use anyhow::Result; | ||
|
|
||
| use crate::app; | ||
|
|
||
| /// Check that the 3rd-party license file is up to date | ||
| #[derive(clap::Args, Debug)] | ||
| #[command()] | ||
| pub struct Cli {} | ||
|
|
||
| impl Cli { | ||
| pub fn exec(self) -> Result<()> { | ||
| app::exec("rust-license-tool", ["check"], true) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sources don't actually include either a
repositoryorhomepageline in their respective metadata, so we can't automatically determine where they are actually hosted.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth PRing these few upstream to reduce the manual work here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, probably.