feat(amqp): added integration test for TLS#17219
feat(amqp): added integration test for TLS#17219dkhokhlov wants to merge 1 commit intovectordotdev:masterfrom
Conversation
✅ Deploy Preview for vector-project canceled.
|
✅ Deploy Preview for vrl-playground canceled.
|
4f8f30d to
762401b
Compare
|
@jonathanpv |
- added integration test for TLS - new test certs for rabbitmq Ref: LOG-16435 Signed-off-by: Dmitri Khokhlov <dkhokhlov@gmail.com>
|
@dkhokhlov Not 100% certain how this one might be similar to what you're trying to accomplish: Here's the relevant block for what the The code that handles the dependency thought might be here: Later on we plan on injecting the runner block in |
Regression Detector ResultsRun ID: bf2e8a78-69f7-43e9-9fab-e323b4f72a06 ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
| volumes: | ||
| - ${PWD}:/code | ||
|
|
||
| wait_for_rabbitmq: |
There was a problem hiding this comment.
Thinking about it, I'm not actually sure why this is necessary now? Does it take longer for a TLS enabled rabbitmq to start up?
If a pause is necessary, it might be easier to put the pause and run the healthcheck at the start of the test in the rust code.
There was a problem hiding this comment.
It was needed even for test w/o TLS, in old int test framework. without the wait the test will fail because rabbitmq can be not ready by the time the test runs. especially when docker build kit is enabled. It seems it is still needed in new test framework. rabbitmq image itself does not support healthcheck. I had to add the second service for that. Going to look into rs approach you mentioned.
|
Closing in favour of #18813. |
feat(amqp): added integration test for TLS
amqpsink doesn't support PEM encoded certificates #16888