Skip to content

chore(releasing): Fix release channels #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jszwedko merged 3 commits into from
Apr 12, 2023
Merged

chore(releasing): Fix release channels #17133

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ac1903
chore(releasing): Fix release channel for S3
jszwedko Apr 12, 2023
7329193
Rename some more instances of `latest` channel
jszwedko Apr 12, 2023
b4f7bdf
One more release channel fix
jszwedko Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/release-s3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ if [[ "$CHANNEL" == "nightly" ]]; then
"https://packages.timber.io/vector/nightly/latest/vector-nightly-x86_64-unknown-linux-gnu.tar.gz" \
"$td_nightly/vector-nightly-x86_64-unknown-linux-gnu.tar.gz"

elif [[ "$CHANNEL" == "latest" ]]; then
elif [[ "$CHANNEL" == "release" ]]; then

@jszwedko jszwedko Apr 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches new release channel name (used to be latest).

@neuronull neuronull Apr 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 when did that channel name change?

@jszwedko jszwedko Apr 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was part of #17024 since it unified the channel and mode parameters.

@neuronull neuronull Apr 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was afraid of that...

VERSION_EXACT="$VERSION"
# shellcheck disable=SC2001
VERSION_MINOR_X="$(echo "$VERSION" | sed 's/\.[0-9]*$/.X/g')"
Expand Down