feat(component spec validation tests): add partial support for component_discarded_events_total metrics#16935
Closed
davidhuie-dd wants to merge 1 commit intodh/error-metrics-validationfrom
Closed
feat(component spec validation tests): add partial support for component_discarded_events_total metrics#16935davidhuie-dd wants to merge 1 commit intodh/error-metrics-validationfrom
component_discarded_events_total metrics#16935davidhuie-dd wants to merge 1 commit intodh/error-metrics-validationfrom
Conversation
Regression Detector ResultsRun ID: 27df08c6-2c2d-4399-94bd-ff28fd12814a ExplanationA regression test is an integrated performance test for The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
neuronull
reviewed
Mar 24, 2023
| .expect("should not fail to encode input event"); | ||
| } | ||
| TestEvent::Interrupted { | ||
| interrupted: _, |
Contributor
There was a problem hiding this comment.
can these two cases be combined since they are identical?
jszwedko
added
meta: blocked
|
David Huie seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
The code this touches has changed on master with changes I've made to the area so this PR is no longer suitable to merge as is and the logic it introduced is already covered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16842
This introduces a test function that can verify the
component_discarded_events_totalmetric total according to a new test event type:TestEvent::Interrupted.I don't actually introduce any actual test harness support for this metric here since it is going to be an involved process per component. We'll have to bring up the full integration test harness, then interrupt the event transmission process midway through in order to trigger these errors. I imagine that we will only do this to our most important integrations due to the high cost of implementing support for this metric.