Skip to content

Change ClickHouse Docker repository.#16371

Closed
alexey-milovidov wants to merge 2 commits intovectordotdev:masterfrom
alexey-milovidov:patch-1
Closed

Change ClickHouse Docker repository.#16371
alexey-milovidov wants to merge 2 commits intovectordotdev:masterfrom
alexey-milovidov:patch-1

Conversation

@alexey-milovidov
Copy link

New versions are located in clickhouse/clickhouse-server only.

@bits-bot
Copy link

bits-bot commented Feb 8, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for vrl-playground ready!

Name Link
🔨 Latest commit 5167ae5
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/641db11916b6710007456255
😎 Deploy Preview https://deploy-preview-16371--vrl-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 8, 2023

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit 5167ae5
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/641db11910d54d0008ad1b93
😎 Deploy Preview https://deploy-preview-16371--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Regression Test Results

Run ID: 1f5dd45d-2b72-4002-8ec8-6d9a9a11e037
Baseline: 31a82a5
Comparison: 9a3ffa8
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparison SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

Changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%:

experiment Δ mean Δ mean % confidence
datadog_agent_remap_blackhole 2.3MiB/CPU-s 8.0 100.00%
syslog_log2metric_splunk_hec_metrics 501.9KiB/CPU-s 5.64 100.00%
Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_blackhole 2.3MiB/CPU-s 8.0 100.00% 28.72MiB/CPU-s 4.03MiB/CPU-s 53.36KiB/CPU-s 0.0 0.140485 31.02MiB/CPU-s 1.06MiB/CPU-s 13.98KiB/CPU-s 0.0 0.034104 True False
syslog_log2metric_splunk_hec_metrics 501.9KiB/CPU-s 5.64 100.00% 8.68MiB/CPU-s 608.34KiB/CPU-s 7.85KiB/CPU-s 0.0 0.068404 9.17MiB/CPU-s 315.07KiB/CPU-s 4.07KiB/CPU-s 0.0 0.033535 False False
datadog_agent_remap_datadog_logs_acks 835.62KiB/CPU-s 2.51 100.00% 32.52MiB/CPU-s 1.97MiB/CPU-s 26.1KiB/CPU-s 0.0 0.060723 33.34MiB/CPU-s 1.1MiB/CPU-s 14.53KiB/CPU-s 0.0 0.032973 False False
syslog_log2metric_humio_metrics 94.26KiB/CPU-s 1.56 100.00% 5.89MiB/CPU-s 337.38KiB/CPU-s 4.36KiB/CPU-s 0.0 0.055979 5.98MiB/CPU-s 198.51KiB/CPU-s 2.56KiB/CPU-s 0.0 0.03243 False False
datadog_agent_remap_blackhole_acks 467.19KiB/CPU-s 1.53 100.00% 29.86MiB/CPU-s 1.86MiB/CPU-s 24.62KiB/CPU-s 0.0 0.062357 30.31MiB/CPU-s 1.67MiB/CPU-s 22.01KiB/CPU-s 0.0 0.054923 False False
http_text_to_http_json 374.12KiB/CPU-s 1.47 100.00% 24.94MiB/CPU-s 769.76KiB/CPU-s 9.94KiB/CPU-s 0.0 0.030141 25.3MiB/CPU-s 620.13KiB/CPU-s 8.0KiB/CPU-s 0.0 0.023931 False False
syslog_regex_logs2metric_ddmetrics 40.02KiB/CPU-s 1.11 100.00% 3.52MiB/CPU-s 463.73KiB/CPU-s 5.98KiB/CPU-s 0.0 0.128556 3.56MiB/CPU-s 333.78KiB/CPU-s 4.31KiB/CPU-s 0.0 0.091516 True False
otlp_http_to_blackhole 13.85KiB/CPU-s 0.89 100.00% 1.52MiB/CPU-s 128.57KiB/CPU-s 1.66KiB/CPU-s 0.0 0.082399 1.54MiB/CPU-s 127.06KiB/CPU-s 1.64KiB/CPU-s 0.0 0.080712 False False
enterprise_http_to_http 12.31KiB/CPU-s 0.09 99.14% 13.61MiB/CPU-s 329.05KiB/CPU-s 4.25KiB/CPU-s 0.0 0.023605 13.62MiB/CPU-s 152.9KiB/CPU-s 1.97KiB/CPU-s 0.0 0.010959 False False
syslog_loki 6.98KiB/CPU-s 0.08 71.51% 8.81MiB/CPU-s 328.28KiB/CPU-s 4.24KiB/CPU-s 0.0 0.036376 8.82MiB/CPU-s 384.33KiB/CPU-s 4.96KiB/CPU-s 0.0 0.042555 False False
http_to_http_noack 6.26KiB/CPU-s 0.04 71.02% 13.61MiB/CPU-s 357.33KiB/CPU-s 4.61KiB/CPU-s 0.0 0.025638 13.62MiB/CPU-s 287.16KiB/CPU-s 3.71KiB/CPU-s 0.0 0.020594 False False
splunk_hec_to_splunk_hec_logs_noack 4.18KiB/CPU-s 0.03 72.58% 13.62MiB/CPU-s 227.51KiB/CPU-s 2.94KiB/CPU-s 0.0 0.01631 13.63MiB/CPU-s 189.76KiB/CPU-s 2.45KiB/CPU-s 0.0 0.0136 False False
http_to_http_json -36.76B/CPU-s -0.0 0.74% 13.62MiB/CPU-s 210.64KiB/CPU-s 2.72KiB/CPU-s 0.0 0.015099 13.62MiB/CPU-s 213.27KiB/CPU-s 2.75KiB/CPU-s 0.0 0.015287 False False
fluent_elasticsearch 166.45B/CPU-s 0.0 23.61% 45.41MiB/CPU-s 30.15KiB/CPU-s 393.95B/CPU-s 0.0 0.000648 45.41MiB/CPU-s 29.82KiB/CPU-s 389.66B/CPU-s 0.0 0.000641 False False
splunk_hec_indexer_ack_blackhole -1.72KiB/CPU-s -0.01 29.15% 13.62MiB/CPU-s 247.63KiB/CPU-s 3.19KiB/CPU-s 0.0 0.017757 13.62MiB/CPU-s 256.33KiB/CPU-s 3.31KiB/CPU-s 0.0 0.018383 False False
splunk_hec_to_splunk_hec_logs_acks -1.51KiB/CPU-s -0.01 18.04% 13.62MiB/CPU-s 364.18KiB/CPU-s 4.7KiB/CPU-s 0.0 0.026113 13.62MiB/CPU-s 360.29KiB/CPU-s 4.65KiB/CPU-s 0.0 0.025836 False False
file_to_blackhole -5.66KiB/CPU-s -0.01 20.96% 54.49MiB/CPU-s 1.13MiB/CPU-s 14.99KiB/CPU-s 0.0 0.020825 54.49MiB/CPU-s 1.14MiB/CPU-s 15.1KiB/CPU-s 0.0 0.020994 False False
http_to_http_acks -15.94KiB/CPU-s -0.3 24.39% 5.26MiB/CPU-s 2.76MiB/CPU-s 36.45KiB/CPU-s 0.0 0.524321 5.25MiB/CPU-s 2.73MiB/CPU-s 36.11KiB/CPU-s 0.0 0.52082 True False
otlp_grpc_to_blackhole -13.04KiB/CPU-s -1.24 100.00% 1.03MiB/CPU-s 48.6KiB/CPU-s 642.34B/CPU-s 0.0 0.046176 1.01MiB/CPU-s 56.29KiB/CPU-s 743.81B/CPU-s 0.0 0.054155 False False
datadog_agent_remap_datadog_logs -428.63KiB/CPU-s -1.25 100.00% 33.43MiB/CPU-s 1.57MiB/CPU-s 20.76KiB/CPU-s 0.0 0.047003 33.01MiB/CPU-s 2.31MiB/CPU-s 30.46KiB/CPU-s 0.0 0.069846 False False
socket_to_socket_blackhole -233.74KiB/CPU-s -1.73 100.00% 13.23MiB/CPU-s 334.29KiB/CPU-s 4.31KiB/CPU-s 0.0 0.024676 13.0MiB/CPU-s 635.46KiB/CPU-s 8.21KiB/CPU-s 0.0 0.047731 False False
splunk_hec_route_s3 -257.38KiB/CPU-s -2.18 100.00% 11.54MiB/CPU-s 590.54KiB/CPU-s 7.62KiB/CPU-s 0.0 0.049982 11.29MiB/CPU-s 674.76KiB/CPU-s 8.71KiB/CPU-s 0.0 0.058381 False False
syslog_humio_logs -342.86KiB/CPU-s -3.69 100.00% 9.07MiB/CPU-s 188.61KiB/CPU-s 2.43KiB/CPU-s 0.0 0.020295 8.74MiB/CPU-s 749.17KiB/CPU-s 9.67KiB/CPU-s 0.0 0.0837 False False
syslog_splunk_hec_logs -342.2KiB/CPU-s -3.72 100.00% 8.98MiB/CPU-s 199.64KiB/CPU-s 2.58KiB/CPU-s 0.0 0.021706 8.65MiB/CPU-s 322.01KiB/CPU-s 4.16KiB/CPU-s 0.0 0.036364 False False

Copy link
Contributor

@davidhuie-dd davidhuie-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we might have to merge in master to have the tests pass.

@davidhuie-dd
Copy link
Contributor

davidhuie-dd commented Feb 9, 2023

Actually, it looks like the tag we're trying to pull here doesn't exist (clickhouse/clickhouse-server:19): https://github.com/vectordotdev/vector/actions/runs/4129481082/jobs/7153010391

@alexey-milovidov
Copy link
Author

If we change the tag to 23, should it work?

@davidhuie-dd
Copy link
Contributor

It looks like that tag should work. After updating the version, you should be able to test locally with the command: cargo vdev integration test clickhouse

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@github-actions
Copy link

Regression Detector Results

Run ID: a5405296-b013-437e-8143-70a2f7284abf
Baseline: 3c03350
Comparison: 5167ae5
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine quickly if vector performance is changed and to what degree by a pull request.

The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed.

Changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%:

experiment goal Δ mean Δ mean % confidence
datadog_agent_remap_datadog_logs_acks ingress throughput 2.28MiB/CPU-s 7.41 100.00%
http_text_to_http_json ingress throughput 1.72MiB/CPU-s 7.17 100.00%
datadog_agent_remap_datadog_logs ingress throughput 2.18MiB/CPU-s 6.89 100.00%
syslog_loki ingress throughput 477.23KiB/CPU-s 5.54 100.00%
Fine details of change detection per experiment.
experiment goal Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
datadog_agent_remap_datadog_logs_acks ingress throughput 2.28MiB/CPU-s 7.41 100.00% 30.79MiB/CPU-s 1.13MiB/CPU-s 14.21KiB/CPU-s 0.0 0.036623 33.08MiB/CPU-s 1.51MiB/CPU-s 19.06KiB/CPU-s 0.0 0.045754 False False
http_text_to_http_json ingress throughput 1.72MiB/CPU-s 7.17 100.00% 23.98MiB/CPU-s 647.31KiB/CPU-s 7.97KiB/CPU-s 0.0 0.026363 25.7MiB/CPU-s 632.14KiB/CPU-s 7.78KiB/CPU-s 0.0 0.024022 False False
datadog_agent_remap_datadog_logs ingress throughput 2.18MiB/CPU-s 6.89 100.00% 31.59MiB/CPU-s 948.36KiB/CPU-s 11.67KiB/CPU-s 0.0 0.029314 33.77MiB/CPU-s 1.11MiB/CPU-s 14.03KiB/CPU-s 0.0 0.032972 False False
syslog_loki ingress throughput 477.23KiB/CPU-s 5.54 100.00% 8.4MiB/CPU-s 208.93KiB/CPU-s 2.57KiB/CPU-s 0.0 0.024274 8.87MiB/CPU-s 237.59KiB/CPU-s 2.92KiB/CPU-s 0.0 0.026154 False False
datadog_agent_remap_blackhole ingress throughput 1.32MiB/CPU-s 4.40 100.00% 29.99MiB/CPU-s 1.56MiB/CPU-s 19.66KiB/CPU-s 0.0 0.05202 31.31MiB/CPU-s 1.25MiB/CPU-s 15.76KiB/CPU-s 0.0 0.039955 False False
syslog_splunk_hec_logs ingress throughput 379.01KiB/CPU-s 4.28 100.00% 8.66MiB/CPU-s 347.49KiB/CPU-s 4.27KiB/CPU-s 0.0 0.039198 9.03MiB/CPU-s 177.64KiB/CPU-s 2.19KiB/CPU-s 0.0 0.019216 False False
syslog_humio_logs ingress throughput 288.38KiB/CPU-s 3.18 100.00% 8.85MiB/CPU-s 211.14KiB/CPU-s 2.6KiB/CPU-s 0.0 0.0233 9.13MiB/CPU-s 237.26KiB/CPU-s 2.92KiB/CPU-s 0.0 0.025375 False False
syslog_regex_logs2metric_ddmetrics ingress throughput 104.09KiB/CPU-s 2.81 100.00% 3.62MiB/CPU-s 449.09KiB/CPU-s 5.53KiB/CPU-s 0.0 0.121133 3.72MiB/CPU-s 439.87KiB/CPU-s 5.41KiB/CPU-s 0.0 0.115407 True True
socket_to_socket_blackhole ingress throughput 337.22KiB/CPU-s 2.47 100.00% 13.31MiB/CPU-s 355.28KiB/CPU-s 4.37KiB/CPU-s 0.0 0.02606 13.64MiB/CPU-s 273.54KiB/CPU-s 3.36KiB/CPU-s 0.0 0.01958 False False
syslog_log2metric_splunk_hec_metrics ingress throughput 197.2KiB/CPU-s 2.12 100.00% 9.07MiB/CPU-s 344.86KiB/CPU-s 4.24KiB/CPU-s 0.0 0.03711 9.27MiB/CPU-s 354.49KiB/CPU-s 4.36KiB/CPU-s 0.0 0.037354 False False
otlp_grpc_to_blackhole ingress throughput 17.83KiB/CPU-s 1.73 100.00% 1.0MiB/CPU-s 51.16KiB/CPU-s 644.66B/CPU-s 0.0 0.049741 1.02MiB/CPU-s 46.16KiB/CPU-s 581.78B/CPU-s 0.0 0.044111 False False
http_to_http_acks ingress throughput 90.22KiB/CPU-s 1.68 93.18% 5.23MiB/CPU-s 2.75MiB/CPU-s 34.62KiB/CPU-s 0.0 0.525295 5.32MiB/CPU-s 2.8MiB/CPU-s 35.32KiB/CPU-s 0.0 0.527071 True False
syslog_log2metric_humio_metrics ingress throughput 100.69KiB/CPU-s 1.66 100.00% 5.93MiB/CPU-s 258.18KiB/CPU-s 3.18KiB/CPU-s 0.0 0.042548 6.02MiB/CPU-s 253.46KiB/CPU-s 3.12KiB/CPU-s 0.0 0.041089 False False
splunk_hec_route_s3 ingress throughput 58.53KiB/CPU-s 0.50 100.00% 11.5MiB/CPU-s 622.98KiB/CPU-s 7.67KiB/CPU-s 0.0 0.052903 11.56MiB/CPU-s 609.04KiB/CPU-s 7.49KiB/CPU-s 0.0 0.051463 False False
enterprise_http_to_http ingress throughput 9.6KiB/CPU-s 0.07 98.12% 13.62MiB/CPU-s 294.76KiB/CPU-s 3.63KiB/CPU-s 0.0 0.021141 13.62MiB/CPU-s 152.63KiB/CPU-s 1.88KiB/CPU-s 0.0 0.010939 False False
http_to_http_json ingress throughput 6.78KiB/CPU-s 0.05 90.99% 13.61MiB/CPU-s 243.59KiB/CPU-s 3.0KiB/CPU-s 0.0 0.017471 13.62MiB/CPU-s 215.76KiB/CPU-s 2.65KiB/CPU-s 0.0 0.015468 False False
splunk_hec_to_splunk_hec_logs_acks ingress throughput -182.55B/CPU-s -0.00 2.19% 13.61MiB/CPU-s 368.17KiB/CPU-s 4.53KiB/CPU-s 0.0 0.026407 13.61MiB/CPU-s 377.25KiB/CPU-s 4.64KiB/CPU-s 0.0 0.027059 False False
fluent_elasticsearch ingress throughput -71.3B/CPU-s -0.00 10.64% 45.41MiB/CPU-s 30.16KiB/CPU-s 375.98B/CPU-s 0.0 0.000648 45.41MiB/CPU-s 30.29KiB/CPU-s 377.59B/CPU-s 0.0 0.000651 False False
http_to_http_noack ingress throughput -2.08KiB/CPU-s -0.01 24.19% 13.61MiB/CPU-s 377.38KiB/CPU-s 4.64KiB/CPU-s 0.0 0.027081 13.61MiB/CPU-s 397.79KiB/CPU-s 4.89KiB/CPU-s 0.0 0.02855 False False
splunk_hec_to_splunk_hec_logs_noack ingress throughput -774.53B/CPU-s -0.01 13.54% 13.62MiB/CPU-s 253.7KiB/CPU-s 3.12KiB/CPU-s 0.0 0.018193 13.62MiB/CPU-s 256.08KiB/CPU-s 3.15KiB/CPU-s 0.0 0.018365 False False
splunk_hec_indexer_ack_blackhole ingress throughput -1.86KiB/CPU-s -0.01 32.89% 13.62MiB/CPU-s 247.38KiB/CPU-s 3.04KiB/CPU-s 0.0 0.017739 13.62MiB/CPU-s 256.04KiB/CPU-s 3.15KiB/CPU-s 0.0 0.018362 False False
datadog_agent_remap_blackhole_acks ingress throughput -150.68KiB/CPU-s -0.48 100.00% 30.88MiB/CPU-s 1.08MiB/CPU-s 13.58KiB/CPU-s 0.0 0.034897 30.74MiB/CPU-s 1.33MiB/CPU-s 16.73KiB/CPU-s 0.0 0.043169 False False
otlp_http_to_blackhole ingress throughput -13.47KiB/CPU-s -0.84 100.00% 1.56MiB/CPU-s 103.71KiB/CPU-s 1.28KiB/CPU-s 0.0 0.064778 1.55MiB/CPU-s 115.59KiB/CPU-s 1.42KiB/CPU-s 0.0 0.072807 False False
file_to_blackhole egress throughput -89.35KiB/CPU-s -1.30 38.35% 6.7MiB/CPU-s 4.24MiB/CPU-s 124.96KiB/CPU-s 4.063018 0.632133 6.61MiB/CPU-s 4.24MiB/CPU-s 127.28KiB/CPU-s 3.522337 0.640878 True True

@dsmith3197
Copy link
Contributor

Done in #17723

@dsmith3197 dsmith3197 closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants