Skip to content

chore(dev): Re-triage done issues with new comment#15720

Merged
jszwedko merged 1 commit intomasterfrom
jszwedko/move-done-to-backlog
Mar 24, 2023
Merged

chore(dev): Re-triage done issues with new comment#15720
jszwedko merged 1 commit intomasterfrom
jszwedko/move-done-to-backlog

Conversation

@jszwedko
Copy link
Collaborator

When a new issue comment is added to an issue that had already been triaged, triage it again.

Signed-off-by: Jesse Szwedko jesse.szwedko@datadoghq.com

When a new issue comment is added to an issue that had already been triaged, triage it again.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for vector-project ready!

Name Link
🔨 Latest commit e0a7fa8
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/63a60e51313c440008d29c90
😎 Deploy Preview https://deploy-preview-15720--vector-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit e0a7fa8
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/63a60e51a2b438000826fad3

@github-actions
Copy link

Regression Test Results

Run ID: d05d6190-32e2-47e0-9183-49a9cf75990f
Baseline: 3c9e41f
Comparison: e0a7fa8
Total vector CPUs: 7

Explanation

A regression test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core.

The table below, if present, lists those experiments that have experienced a statistically significant change in their bytes_written_per_cpu_second performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±5% change in mean bytes_written_per_cpu_second are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting changes are observed.

No interesting changes in bytes_written_per_cpu_second with confidence ≥ 90.00% and absolute Δ mean >= ±5%.

Fine details of change detection per experiment.
experiment Δ mean Δ mean % confidence baseline mean baseline stdev baseline stderr baseline outlier % baseline CoV comparison mean comparison stdev comparison stderr comparison outlier % comparison CoV erratic declared erratic
http_text_to_http_json 231.51KiB/CPU-s 0.91 100.00% 24.77MiB/CPU-s 716.22KiB/CPU-s 9.25KiB/CPU-s 0.0 0.028232 25.0MiB/CPU-s 569.43KiB/CPU-s 7.35KiB/CPU-s 0.0 0.022243 False False
http_to_http_acks 27.56KiB/CPU-s 0.51 40.72% 5.26MiB/CPU-s 2.74MiB/CPU-s 36.25KiB/CPU-s 0.0 0.52176 5.28MiB/CPU-s 2.77MiB/CPU-s 36.63KiB/CPU-s 0.0 0.524616 True False
syslog_log2metric_humio_metrics 28.33KiB/CPU-s 0.46 100.00% 6.02MiB/CPU-s 149.12KiB/CPU-s 1.93KiB/CPU-s 0.0 0.024206 6.04MiB/CPU-s 81.76KiB/CPU-s 1.06KiB/CPU-s 0.0 0.013211 False False
otlp_grpc_to_blackhole 2.4KiB/CPU-s 0.23 99.48% 1.01MiB/CPU-s 44.82KiB/CPU-s 592.43B/CPU-s 0.0 0.043437 1.01MiB/CPU-s 49.15KiB/CPU-s 649.56B/CPU-s 0.0 0.047523 False False
datadog_agent_remap_datadog_logs_acks 40.21KiB/CPU-s 0.12 94.04% 32.97MiB/CPU-s 1.25MiB/CPU-s 16.46KiB/CPU-s 0.0 0.03778 33.01MiB/CPU-s 1.03MiB/CPU-s 13.59KiB/CPU-s 0.0 0.031147 False False
enterprise_http_to_http 12.59KiB/CPU-s 0.09 99.22% 13.61MiB/CPU-s 334.02KiB/CPU-s 4.31KiB/CPU-s 0.0 0.023962 13.62MiB/CPU-s 151.38KiB/CPU-s 1.95KiB/CPU-s 0.0 0.01085 False False
splunk_hec_to_splunk_hec_logs_noack 7.89KiB/CPU-s 0.06 94.79% 13.62MiB/CPU-s 249.25KiB/CPU-s 3.22KiB/CPU-s 0.0 0.017873 13.63MiB/CPU-s 192.09KiB/CPU-s 2.48KiB/CPU-s 0.0 0.013767 False False
socket_to_socket_blackhole 6.01KiB/CPU-s 0.04 94.89% 13.59MiB/CPU-s 201.89KiB/CPU-s 2.61KiB/CPU-s 0.0 0.014503 13.6MiB/CPU-s 127.12KiB/CPU-s 1.64KiB/CPU-s 0.0 0.009128 False False
splunk_hec_to_splunk_hec_logs_acks -37.31B/CPU-s -0.0 0.47% 13.62MiB/CPU-s 337.73KiB/CPU-s 4.36KiB/CPU-s 0.0 0.024222 13.62MiB/CPU-s 337.48KiB/CPU-s 4.35KiB/CPU-s 0.0 0.024204 False False
datadog_agent_remap_blackhole 1.35KiB/CPU-s 0.0 5.81% 30.93MiB/CPU-s 1.08MiB/CPU-s 14.22KiB/CPU-s 0.0 0.034782 30.93MiB/CPU-s 922.43KiB/CPU-s 11.9KiB/CPU-s 0.0 0.029122 False False
fluent_elasticsearch -410.11B/CPU-s -0.0 53.66% 45.41MiB/CPU-s 30.18KiB/CPU-s 394.64B/CPU-s 0.0 0.000649 45.41MiB/CPU-s 30.3KiB/CPU-s 396.25B/CPU-s 0.0 0.000652 False False
file_to_blackhole 1.2KiB/CPU-s 0.0 4.55% 54.49MiB/CPU-s 1.15MiB/CPU-s 15.18KiB/CPU-s 0.0 0.021088 54.49MiB/CPU-s 1.1MiB/CPU-s 14.47KiB/CPU-s 0.0 0.02011 False False
http_to_http_json -145.25B/CPU-s -0.0 3.00% 13.62MiB/CPU-s 207.23KiB/CPU-s 2.67KiB/CPU-s 0.0 0.014854 13.62MiB/CPU-s 206.31KiB/CPU-s 2.66KiB/CPU-s 0.0 0.014789 False False
splunk_hec_indexer_ack_blackhole -832.47B/CPU-s -0.01 14.37% 13.62MiB/CPU-s 244.4KiB/CPU-s 3.15KiB/CPU-s 0.0 0.017524 13.62MiB/CPU-s 247.81KiB/CPU-s 3.2KiB/CPU-s 0.0 0.017769 False False
http_to_http_noack -6.31KiB/CPU-s -0.05 71.69% 13.62MiB/CPU-s 284.0KiB/CPU-s 3.67KiB/CPU-s 0.0 0.020367 13.61MiB/CPU-s 356.45KiB/CPU-s 4.6KiB/CPU-s 0.0 0.025575 False False
syslog_regex_logs2metric_ddmetrics -6.11KiB/CPU-s -0.16 55.91% 3.77MiB/CPU-s 433.44KiB/CPU-s 5.6KiB/CPU-s 0.0 0.112255 3.76MiB/CPU-s 434.63KiB/CPU-s 5.61KiB/CPU-s 0.0 0.11274 True False
datadog_agent_remap_datadog_logs -67.77KiB/CPU-s -0.2 99.10% 32.99MiB/CPU-s 1.38MiB/CPU-s 18.26KiB/CPU-s 0.0 0.041906 32.92MiB/CPU-s 1.39MiB/CPU-s 18.4KiB/CPU-s 0.0 0.0423 False False
datadog_agent_remap_blackhole_acks -145.57KiB/CPU-s -0.47 100.00% 30.54MiB/CPU-s 981.18KiB/CPU-s 12.67KiB/CPU-s 0.0 0.03137 30.4MiB/CPU-s 1.28MiB/CPU-s 16.96KiB/CPU-s 0.0 0.042208 False False
otlp_http_to_blackhole -7.89KiB/CPU-s -0.51 99.97% 1.52MiB/CPU-s 115.52KiB/CPU-s 1.49KiB/CPU-s 0.0 0.074085 1.51MiB/CPU-s 123.97KiB/CPU-s 1.6KiB/CPU-s 0.0 0.079908 False False
syslog_humio_logs -58.34KiB/CPU-s -0.65 100.00% 8.76MiB/CPU-s 208.16KiB/CPU-s 2.69KiB/CPU-s 0.0 0.023195 8.71MiB/CPU-s 208.27KiB/CPU-s 2.69KiB/CPU-s 0.0 0.02336 False False
splunk_hec_route_s3 -82.67KiB/CPU-s -0.7 100.00% 11.54MiB/CPU-s 631.63KiB/CPU-s 8.15KiB/CPU-s 0.0 0.053461 11.46MiB/CPU-s 665.06KiB/CPU-s 8.58KiB/CPU-s 0.0 0.056687 False False
syslog_log2metric_splunk_hec_metrics -82.56KiB/CPU-s -0.88 100.00% 9.13MiB/CPU-s 214.67KiB/CPU-s 2.77KiB/CPU-s 0.0 0.022969 9.05MiB/CPU-s 238.72KiB/CPU-s 3.08KiB/CPU-s 0.0 0.025771 False False
syslog_loki -111.69KiB/CPU-s -1.31 100.00% 8.32MiB/CPU-s 252.52KiB/CPU-s 3.26KiB/CPU-s 0.0 0.029633 8.21MiB/CPU-s 264.19KiB/CPU-s 3.41KiB/CPU-s 0.0 0.031414 False False
syslog_splunk_hec_logs -144.9KiB/CPU-s -1.64 100.00% 8.62MiB/CPU-s 173.08KiB/CPU-s 2.23KiB/CPU-s 0.0 0.019598 8.48MiB/CPU-s 196.25KiB/CPU-s 2.53KiB/CPU-s 0.0 0.022592 False False

Copy link
Contributor

@spencergilbert spencergilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended as "we close this thinking it's completed/no longer relevant - but a new comment should add it back into our workflow?"

# ids fetched from https://docs.github.com/en/graphql/overview/explorer
project_id="PVT_kwDOAQFeYs4AAsTr" # Gardener
issue_id=${{ github.event.issue.node_id }}
status_field_id="PVTSSF_lADOAQFeYs4AAsTrzgAXRuU" # Status
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just awful 😄

@jszwedko
Copy link
Collaborator Author

This is intended as "we close this thinking it's completed/no longer relevant - but a new comment should add it back into our workflow?"

Yeah, that's my thinking. That a comment on a "triaged" issue should trigger another look. Often it'll just be moving it back to Done though.

@jszwedko jszwedko merged commit 3c03350 into master Mar 24, 2023
@jszwedko jszwedko deleted the jszwedko/move-done-to-backlog branch March 24, 2023 14:09
jszwedko added a commit that referenced this pull request Mar 24, 2023
jszwedko added a commit that referenced this pull request Mar 24, 2023
Revert "chore(dev): Re-triage done issues with new comment (#15720)"

This reverts commit 3c03350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants