fix(ci): Correct github.actions.rest to github.rest.actions #15153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #15142 we introduced the split between the trusted and untrusted regresison detector workflow. Unfortunately the trusted side can only be tested once it's merged into master branch and we had a bug. The github-scripts that download artifacts referenced `github.actions.rest` when it should have read `github.rest.actions`. Please note that because of the nature of workflow_run triggered workflows this change will not be reflected in the PR's workflow runs. Signed-off-by: Brian L. Troutwine <[email protected]>
✅ Deploy Preview for vrl-playground canceled.
|
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Soak Test ResultsBaseline: 067795e ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
goxberry
approved these changes
Nov 9, 2022
spencergilbert
approved these changes
Nov 9, 2022
Contributor
spencergilbert
left a comment
spencergilbert
left a comment
There was a problem hiding this comment.
I love how wonky it is developing github actions 😄
Contributor
💯 |
Contributor
Author
It's not my favorite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #15142 we introduced the split between the trusted and untrusted regresison detector workflow. Unfortunately the trusted side can only be tested once it's merged into master branch and we had a bug. The github-scripts that download artifacts referenced
github.actions.restwhen it should have readgithub.rest.actions.Please note that because of the nature of workflow_run triggered workflows this change will not be reflected in the PR's workflow runs.
Signed-off-by: Brian L. Troutwine [email protected]