enhancement(pulsar sink)Support pulsar topics lookup retry options#14779
Closed
tuteng wants to merge 3 commits intovectordotdev:masterfrom
Closed
enhancement(pulsar sink)Support pulsar topics lookup retry options#14779tuteng wants to merge 3 commits intovectordotdev:masterfrom
tuteng wants to merge 3 commits intovectordotdev:masterfrom
Conversation
|
|
✅ Deploy Preview for vector-project canceled.
|
tuteng
changed the title
tuteng
changed the title
Author
|
Anyone help review this pr? thanks |
Contributor
|
👋 Hi @tuteng ! We have a rather uncommon situation on our hands. There is a separate contributor PR (#14345) , which is refactoring the That change would overwrite your proposed changes here. Since we are striving to get all sinks to be in this new-style, and since this new-style framework has provisions for exposing the retry logic already, I have asked the author of #14345 to include the respective changes to that effect. If for some reason that doesn't happen, it would be a small PR similar to this size or smaller, to enable that. |
Author
|
Repeat with #14345, so closed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enhancement: Support retry option when configuring topic lookup