fix(new_relic sink): Multiple fixes related to metrics#14528
fix(new_relic sink): Multiple fixes related to metrics#14528asllop wants to merge 17 commits intovectordotdev:masterfrom
Conversation
github-actions
bot
added
the
domain: sinks
✅ Deploy Preview for vector-project ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Soak Test ResultsBaseline: a53cfef ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
bruceg
left a comment
bruceg
left a comment
There was a problem hiding this comment.
This looks pretty good, but it appears there is no test coverage for this data. It looks like tests.rs is testing part of what you're changing here, could you update the tests to cover everything?
|
Oh, it also looks like this needs to be merged with the current |
Co-authored-by: Bruce Guenter <bruce@untroubled.org>
❌ Deploy Preview for vrl-playground failed.
|
Co-authored-by: Bruce Guenter <bruce@untroubled.org>
|
@bruceg all the requested changes are made, ready for review. |
Soak Test ResultsBaseline: cf73729 ExplanationA soak test is an integrated performance test for vector in a repeatable rig, with varying configuration for vector. What follows is a statistical summary of a brief vector run for each configuration across SHAs given above. The goal of these tests are to determine, quickly, if vector performance is changed and to what degree by a pull request. Where appropriate units are scaled per-core. The table below, if present, lists those experiments that have experienced a statistically significant change in their throughput performance between baseline and comparision SHAs, with 90.0% confidence OR have been detected as newly erratic. Negative values mean that baseline is faster, positive comparison. Results that do not exhibit more than a ±8.87% change in mean throughput are discarded. An experiment is erratic if its coefficient of variation is greater than 0.3. The abbreviated table will be omitted if no interesting changes are observed. No interesting changes in throughput with confidence ≥ 90.00% and absolute Δ mean >= ±8.87%: Fine details of change detection per experiment.
|
bruceg
left a comment
bruceg
left a comment
There was a problem hiding this comment.
It looks like this just needs a cargo fmt and it's ready to go.
Regression Test Results
Run ID: 5622bb06-7768-49df-a22f-c3fd10f45c94 Explanation
A regression test is an integrated performance test for
The table below, if present, lists those experiments that have experienced a
statistically significant change in their Changes in
Fine details of change detection per experiment.
|
|
Looks like there are some newer compilation errors concerning |
|
@davidhuie-dd ok, let me check, I'll have a look ASAP. |
jszwedko
added
the
meta: awaiting author
|
Hey @asllop ! Just wondering if you think you'll get a chance to circle back to this. |
|
Done in #18151 |
5 participants
Description
MetricsApiModelconstructor.Issues
The following open issues are concerned with this PR:
#13377
#13781
#13902
#13903