This repository has been archived by the owner on Aug 9, 2020. It is now read-only.
WIP feat: Support custom theme #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptbrowne
force-pushed
the
support-custom-theme
branch
from
fce23fd to
d5ff7a0
Compare
Pull Request Test Coverage Report for Build 273
💛 - Coveralls |
Pull Request Test Coverage Report for Build 274
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is possible to use a theme :
To support this, the theme is resolved as early as possible either with syspath.resolve or with require.resolve.
I haven't completely tested this change (default works, custom works but I haven't tested the npm package way), I mainly want to check if this is the direction you want for the themes. What do you think ?