Removes Bower Dependency + Update For Fastboot 1.0 + Update to Ember 2.14 #40

devotox · 2017-07-08T13:59:46Z

This PR brings this package up to the current state of Ember Addons

Remove Bower Dependency
Fastboot Support
Ember Engines Support
Eslint
Ember 2.14

Also closes this issues
#39

houndci-bot · 2017-07-08T13:59:55Z

tests/test-helper.js

@@ -2,5 +2,7 @@ import resolver from './helpers/resolver';
 import {
  setResolver
 } from 'ember-qunit';
+import { start } from 'ember-cli-qunit';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:55Z

tests/helpers/start-app.js

-  Ember.run(function() {
-    application = Application.create(attributes);
+  return Ember.run(() => {
+    let application = Application.create(attributes);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:55Z

tests/helpers/start-app.js

  attributes = Ember.merge(attributes, attrs); // use defaults, but you can override;

-  Ember.run(function() {
-    application = Application.create(attributes);
+  return Ember.run(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/start-app.js

-  var application;
-
-  var attributes = Ember.merge({}, config.APP);
+  let attributes = Ember.merge({}, config.APP);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/resolver.js

 import config from '../../config/environment';

-var resolver = Resolver.create();
+const resolver = Resolver.create();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/module-for-acceptance.js

+import startApp from '../helpers/start-app';
+import destroyApp from '../helpers/destroy-app';
+
+const { RSVP: { resolve } } = Ember;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/module-for-acceptance.js

+import { module } from 'qunit';
+import Ember from 'ember';
+import startApp from '../helpers/start-app';
+import destroyApp from '../helpers/destroy-app';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';
+import Ember from 'ember';
+import startApp from '../helpers/start-app';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';
+import Ember from 'ember';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:56Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/test-helper.js

@@ -2,5 +2,7 @@ import resolver from './helpers/resolver';
 import {
  setResolver
 } from 'ember-qunit';
+import { start } from 'ember-cli-qunit';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/start-app.js

-  Ember.run(function() {
-    application = Application.create(attributes);
+  return Ember.run(() => {
+    let application = Application.create(attributes);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/start-app.js

  attributes = Ember.merge(attributes, attrs); // use defaults, but you can override;

-  Ember.run(function() {
-    application = Application.create(attributes);
+  return Ember.run(() => {


'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/start-app.js

-  var application;
-
-  var attributes = Ember.merge({}, config.APP);
+  let attributes = Ember.merge({}, config.APP);


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/resolver.js

 import config from '../../config/environment';

-var resolver = Resolver.create();
+const resolver = Resolver.create();


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/module-for-acceptance.js

+import startApp from '../helpers/start-app';
+import destroyApp from '../helpers/destroy-app';
+
+const { RSVP: { resolve } } = Ember;


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).
'destructuring binding' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/module-for-acceptance.js

+import { module } from 'qunit';
+import Ember from 'ember';
+import startApp from '../helpers/start-app';
+import destroyApp from '../helpers/destroy-app';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';
+import Ember from 'ember';
+import startApp from '../helpers/start-app';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';
+import Ember from 'ember';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T13:59:57Z

tests/helpers/module-for-acceptance.js

@@ -0,0 +1,23 @@
+import { module } from 'qunit';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T21:35:09Z

tests/dummy/app/app.js

  modulePrefix: config.modulePrefix,
  podModulePrefix: config.podModulePrefix,
-  Resolver: Resolver
+  Resolver


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T21:35:09Z

tests/dummy/app/app.js

 import config from './config/environment';

-Ember.MODEL_FACTORY_INJECTIONS = true;
+let App;


'let' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T21:35:09Z

tests/dummy/app/app.js

-import Resolver from 'ember/resolver';
-import loadInitializers from 'ember/load-initializers';
+import Resolver from './resolver';
+import loadInitializers from 'ember-load-initializers';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T21:35:09Z

tests/dummy/app/app.js

@@ -1,14 +1,14 @@
 import Ember from 'ember';
-import Resolver from 'ember/resolver';
-import loadInitializers from 'ember/load-initializers';
+import Resolver from './resolver';


'import' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/config/environment.js

-    environment: environment,
-    baseURL: '/',
-    locationType: 'none',
+    environment,


'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/config/environment.js

@@ -1,25 +1,30 @@
-/* jshint node: true */
+/* eslint-env node */
+'use strict';


Use the function form of "use strict".

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/app/router.js

 });
+
+export default Router;


'export' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/app/router.js

@@ -1,9 +1,12 @@
 import Ember from 'ember';
 import config from './config/environment';

-var Router = Ember.Router.extend({
-  location: config.locationType
+const Router = Ember.Router.extend({


'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/app/resolver.js

@@ -0,0 +1,3 @@
+import Resolver from 'ember-resolver';
+
+export default Resolver;


'export' is only available in ES6 (use 'esversion: 6').

houndci-bot · 2017-07-08T21:35:10Z

tests/dummy/app/resolver.js

@@ -0,0 +1,3 @@
+import Resolver from 'ember-resolver';


'import' is only available in ES6 (use 'esversion: 6').

mpirio · 2018-05-30T15:21:03Z

@vectart ? Are you still alive ;p ?

benmurden · 2018-06-29T06:08:42Z

@vectart Do you need help getting this merged?

devotox added 2 commits July 8, 2017 14:56

Update to remove bower dependency + Fastboot compatibility

549cd6d

Update to remove bower dependency + Fastboot compatibility

5fd56de

houndci-bot reviewed Jul 8, 2017

View reviewed changes

devotox mentioned this pull request Jul 8, 2017

Add-ons Prep for fastboot 1.0.0 ember-fastboot/ember-cli-fastboot#387

Closed

devotox added 2 commits July 8, 2017 22:30

fix find pace scripts

dc4301b

fix find pace scripts

cd14acf

houndci-bot reviewed Jul 8, 2017

View reviewed changes

options in window

45febdc

mpirio mentioned this pull request May 30, 2018

Is this project still alive? #42

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removes Bower Dependency + Update For Fastboot 1.0 + Update to Ember 2.14 #40

Removes Bower Dependency + Update For Fastboot 1.0 + Update to Ember 2.14 #40

devotox commented Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

houndci-bot Jul 8, 2017

mpirio commented May 30, 2018 •

edited

Loading

benmurden commented Jun 29, 2018

		@@ -0,0 +1,23 @@
		import { module } from 'qunit';
		import Ember from 'ember';

		@@ -0,0 +1,3 @@
		import Resolver from 'ember-resolver';

		export default Resolver;

Removes Bower Dependency + Update For Fastboot 1.0 + Update to Ember 2.14 #40

Are you sure you want to change the base?

Removes Bower Dependency + Update For Fastboot 1.0 + Update to Ember 2.14 #40

Conversation

devotox commented Jul 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpirio commented May 30, 2018 • edited Loading

benmurden commented Jun 29, 2018

mpirio commented May 30, 2018 •

edited

Loading