Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project improvements + a few more emojis #171

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Johnibur
Copy link

@Johnibur Johnibur commented Jan 11, 2021

This adds the feather 🪶 emoji.
This also adds the ladder 🪜 emoji.
This finally adds an alias for the rowing boat emoji.

This updates the emoji table file, and slightly improves and explains the table generator. Finally, this requires Maven to use Java 1.8 as modern compilers cannot produces Java 5 binaries anymore (which is Maven default).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 92.625% when pulling 36c79b7 on Johnibur:add-feather-emoji into 9a90624 on vdurmont:master.

Java 5 is the default target in Maven but is unsupported with new compilers. This makes Maven uses Java 8, which is at least a good compromise.
You need to parse the EMOJIS.json location in order to generate the table.
@Johnibur Johnibur changed the title Add feather emoji Project improvements + a few more emojis Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants