-
Notifications
You must be signed in to change notification settings - Fork 83
Backport PR #2850 to release/v1.7 for Go v1.24.0 migration #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR #2850 to release/v1.7 for Go v1.24.0 migration #2855
Conversation
* add GODEBUG parameter * centralized parameter management --------- Co-authored-by: Kiichiro YUKAWA <[email protected]>
Deploying vald with
|
Latest commit: |
4cf6a75
|
Status: | ✅ Deploy successful! |
Preview URL: | https://1a7d2db3.vald.pages.dev |
Branch Preview URL: | https://backport-release-v1-7-bugfix-1k3e.vald.pages.dev |
📝 WalkthroughWalkthroughThe pull request adds a new line to the Makefile to set the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Makefile
participant TestTarget
participant GoTest
Developer->>Makefile: Execute test command
Makefile->>TestTarget: Propagate GODEBUG variable
TestTarget->>GoTest: Run tests with debugging enabled
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 golangci-lint (1.62.2)level=warning msg="[config_reader] The configuration option 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (2)
🔇 Additional comments (9)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[CHATOPS:HELP] ChatOps commands.
|
Description
add GODEBUG parameter for unit tests
Related Issue
Versions
Checklist
Special notes for your reviewer
Summary by CodeRabbit