Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Release/0.1.18#140

Merged
wjwwood merged 1 commit intomasterfrom
release/0.1.18
Sep 23, 2019
Merged

Release/0.1.18#140
wjwwood merged 1 commit intomasterfrom
release/0.1.18

Conversation

@tkruse
Copy link
Copy Markdown
Contributor

@tkruse tkruse commented Aug 4, 2019

@wjwwood : This pr is the version update ready to be released after vcstools/vcstools#146

Travis failure because new vcstools not released yet.

Feel free to look over the last merged commits.
I'll go ahead with in a week else.

Copy link
Copy Markdown
Contributor

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one comment, lgtm.

stdeb.cfg Outdated
Conflicts: python3-wstool
Conflicts3: python-wstool
Suite: oneiric precise quantal raring saucy trusty utopic vivid wily xenial yakkety zesty artful bionic wheezy jessie stretch buster
Suite: oneiric precise quantal raring saucy trusty utopic vivid wily xenial yakkety zesty artful bionic cosmic disco wheezy jessie stretch buster
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work right now, could you remove those until we have updated our infrastructure to allow it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed.

@tkruse tkruse force-pushed the release/0.1.18 branch 2 times, most recently from 3c85310 to 6792f46 Compare August 12, 2019 06:16
@tkruse
Copy link
Copy Markdown
Contributor Author

tkruse commented Aug 18, 2019

I made a release to testpypi at https://test.pypi.org/project/wstool/. I assume that @wjwwood will again make a combined release.

@wjwwood
Copy link
Copy Markdown
Contributor

wjwwood commented Aug 19, 2019

Sorry, I've been on vacation. I'll get to this as soon as I can.

@tkruse
Copy link
Copy Markdown
Contributor Author

tkruse commented Sep 16, 2019

@wjwwood : reminding ping

@wjwwood wjwwood merged commit 42ce038 into master Sep 23, 2019
@wjwwood wjwwood deleted the release/0.1.18 branch September 23, 2019 21:52
@wjwwood
Copy link
Copy Markdown
Contributor

wjwwood commented Sep 23, 2019

@tkruse sorry for the delay, but while trying to release this I ran into an issue with the setup.py. Unless I comment this line (

wstool/setup.py

Line 125 in 42ce038

tests_require=test_required,
) I get this error when running python3 setup.py sdist bdist_wheel:

...
copying build/scripts-3.6/wstool -> build/bdist.linux-x86_64/wheel/wstool-0.1.18.data/scripts
changing mode of build/bdist.linux-x86_64/wheel/wstool-0.1.18.data/scripts/wstool to 775
Traceback (most recent call last):
  File "setup.py", line 140, in <module>
    license="BSD")
  File "/usr/lib/python3/dist-packages/setuptools/__init__.py", line 129, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python3.6/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib/python3.6/distutils/dist.py", line 955, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
    cmd_obj.run()
  File "/usr/lib/python3/dist-packages/wheel/bdist_wheel.py", line 257, in run
    self.distinfo_dir)
  File "/usr/lib/python3/dist-packages/wheel/bdist_wheel.py", line 427, in egg2dist
    distribution=self.distribution)
  File "/usr/lib/python3/dist-packages/wheel/metadata.py", line 177, in pkginfo_to_dict
    new_requirements = sorted(convert_requirements(requirements))
  File "/usr/lib/python3/dist-packages/wheel/metadata.py", line 234, in convert_requirements
    parsed_requirement = pkg_resources.Requirement.parse(req)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2988, in parse
    req, = parse_requirements(s)
ValueError: not enough values to unpack (expected 1, got 0)

Some details about the machine I was running on:

% python3 -m pip --version
pip 19.2.3 from /usr/local/lib/python3.6/dist-packages/pip (python 3.6)

% python3 -m pip freeze --all | grep setuptools
setuptools==40.8.0

% python3 --version
Python 3.6.8

% lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.3 LTS
Release:	18.04
Codename:	bionic

% which python3
/usr/bin/python3

I poked at it for a while, but I'm not exactly sure what needs to change to avoid breaking how the requirements are being used. If you have some time to look at that I'd appreciate it.

@tkruse
Copy link
Copy Markdown
Contributor Author

tkruse commented Sep 24, 2019

Seems to be same as moremoban/pypi-mobans#37, the comment lines in requirements.txt, depending on some version of setuptools I guess.

@tkruse
Copy link
Copy Markdown
Contributor Author

tkruse commented Sep 24, 2019

My system seems fine, travis also seems fine.
My system wheel:

python3 -m pip freeze --all | grep wheel
wheel==0.33.5

I guess the comment lines can just be removed if all else fails, but maybe you want to give it another shot updating your wheel version first?

@tkruse
Copy link
Copy Markdown
Contributor Author

tkruse commented Sep 24, 2019

I added the command python3 setup.py sdist bdist_wheel to tox.ini being run on travis, to check it is sane on an up-to-date environment

@tkruse tkruse mentioned this pull request Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants