Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Follow symlinks when finding unmanaged repos #106

Closed
jacobperron wants to merge 1 commit into from
Closed

Follow symlinks when finding unmanaged repos #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wstool/multiproject_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ def do_work(self):
managed_paths = [os.path.join(path, e.get_local_name()) for e in elements]
unmanaged_paths = []
scm_clients = {SvnClient: 'svn', GitClient: 'git', BzrClient:'bzr', HgClient:'hg'}
for root, dirs, files in os.walk(path):
for root, dirs, files in os.walk(path, followlinks=True):
Copy link
Copy Markdown
Contributor

@rsinnet rsinnet May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it would be possible to add a test to show this new feature. There are already some good tests in this repo.

Copy link
Copy Markdown

@rhaschke rhaschke May 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have resources to add a test.
By the way, what would you like to test here? os.walk is a system function, that should be tested upstream.

if root in managed_paths:
# remove it from the walk if it's managed
del dirs[:]
Expand Down