Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(PageWrapper): 优化PageWrapper在page的footer与全局页脚同时开启时的高度计算表现。 #760

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

noahlann
Copy link

@noahlann noahlann commented Jun 16, 2021

perf(PageWrapper): 优化PageWrapper在page的footer与全局页脚同时开启时的高度计算表现。

问题

contentHeight 未计算 全局footer 高度,开启PageWrapper的footer时会全局遮挡

解决

  1. 高度计算时,如果全局footer开启,需要减去全局footer
  2. 取消padding-bottom

当前尚未解决被PageWrapper的footer直接遮挡 全局footer 的问题。 PageWrapper的footer是浮动状态。

@anncwb anncwb merged commit ab2c7ef into vbenjs:main Jun 16, 2021
@noahlann noahlann deleted the perf-pagewrapper branch June 17, 2021 02:48
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants