fix(table): table columns setting will uncheck all render columns #154

vbenjs · Jan 2, 2021 · aa596af · aa596af
1 parent 0419a07
commit aa596af
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/components/Table/src/components/editable/EditableCell.vue b/src/components/Table/src/components/editable/EditableCell.vue
@@ -250,7 +250,7 @@
         if (props.record) {
           /* eslint-disable  */
           isArray(props.record[cbs])
-            ? props.record[cbs].push(handle)
+            ? props.record[cbs]?.push(handle)
             : (props.record[cbs] = [handle]);
         }
       }
@@ -267,9 +267,9 @@
         /* eslint-disable */
         props.record.onSubmitEdit = async () => {
           if (isArray(props.record?.submitCbs)) {
-            const validFns = props.record?.validCbs || [];
+            const validFns = (props.record?.validCbs || []).map((fn) => fn());
 
-            const res = await Promise.all(validFns.map((fn) => fn()));
+            const res = await Promise.all(validFns);
             const pass = res.every((item) => !!item);
 
             if (!pass) return;

diff --git a/src/components/Table/src/hooks/useColumns.ts b/src/components/Table/src/hooks/useColumns.ts
@@ -185,13 +185,14 @@ export function useColumns(
       const columnKeys = columns as string[];
       const newColumns: BasicColumn[] = [];
       cacheColumns.forEach((item) => {
-        if (columnKeys.includes(`${item.key}`! || item.dataIndex!)) {
+        if (columnKeys.includes(item.dataIndex! || (item.key as string))) {
           newColumns.push({
             ...item,
             defaultHidden: false,
           });
         }
       });
+
       // Sort according to another array
       if (!isEqual(cacheKeys, columns)) {
         newColumns.sort((prev, next) => {

diff --git a/src/settings/projectSetting.ts b/src/settings/projectSetting.ts
@@ -109,7 +109,7 @@ const setting: ProjectConfig = {
     // Switch page to close menu
     closeMixSidebarOnChange: false,
     // Module opening method ‘click’ |'hover'
-    mixSideTrigger: 'hover',
+    mixSideTrigger: 'click',
   },
 
   // Multi-label