Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(web-core): new Info component #7997

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat(web-core): new Info component #7997

merged 4 commits into from
Sep 25, 2024

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Sep 18, 2024 •
edited
Loading

Screenshots

Capture d’écran de 2024-09-25 14-25-17
Capture d’écran de 2024-09-25 14-25-14
Capture d’écran de 2024-09-25 14-25-12
Capture d’écran de 2024-09-25 14-25-08
Capture d’écran de 2024-09-25 14-24-50

Description

Wait for #8003

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@MathieuRA MathieuRA self-assigned this Sep 18, 2024
@MathieuRA MathieuRA mentioned this pull request Sep 18, 2024
Merged
OlivierFL
OlivierFL requested changes Sep 24, 2024
View reviewed changes
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/stories/web-core/info/ui-info.story.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/web-core/lib/components/info/UiInfo.vue Outdated Show resolved Hide resolved
@xen-orchestra/lite/src/stories/web-core/info/ui-info.story.vue Outdated Show resolved Hide resolved
MelissaFrncJrg
MelissaFrncJrg approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@MelissaFrncJrg MelissaFrncJrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add on my side

@OlivierFL OlivierFL merged commit 13f2afb into master Sep 25, 2024
1 check passed
@OlivierFL OlivierFL deleted the web-core/new-info-component branch September 25, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MelissaFrncJrg MelissaFrncJrg MelissaFrncJrg approved these changes

@OlivierFL OlivierFL OlivierFL approved these changes

Assignees

@MathieuRA MathieuRA

Labels
XO Web Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathieuRA @OlivierFL @MelissaFrncJrg