feat(xo-server, xo-web): warning for too small host TLS keys #7995
+61
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-Nollet
force-pushed
the
warning-short-TLS
branch
4 times, most recently
from
db9c766
to
bd70212
Compare
b-Nollet
changed the title
b-Nollet
force-pushed
the
warning-short-TLS
branch
from
bd70212
to
f47244c
Compare
b-Nollet
force-pushed
the
warning-short-TLS
branch
from
f47244c
to
ed9196f
Compare
julien-f
reviewed
Sep 19, 2024
julien-f
reviewed
Sep 19, 2024
packages/xo-server/src/api/host.mjs
Outdated
| const certificate = await this.getXapi(host).call('host.get_server_certificate', host._xapiRef) | ||
|
|
||
| const cert = new X509Certificate(certificate) | ||
| return cert.publicKey.asymmetricKeyDetails.modulusLength < 2048 |
There was a problem hiding this comment.
Maybe you could use a constant that describes what 2048 is, and that can be reused if needed?
Ex: CERT_PUBKEY_MIN_SIZE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display a warning in host list when host TLS key is too short to update to XCP-ng 8.3
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md