Copy test verififcation #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive copy functionality testing to the machine testing process. The changes integrate file transfer tests (local-to-remote and remote-to-local) into the existing machine validation workflow to ensure instances can properly handle file operations.
- Adds proper session management with try/finally cleanup in HTTP requests
- Implements
run_copy_testfunction that creates SSH keys, performs bidirectional file transfers with 100MB test files, and validates transfer integrity - Integrates copy testing into the machine testing workflow with enhanced logging and monitoring
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+6774
to
+6780
| def run_copy_test(instance_id, api_key, args): | ||
| """ | ||
| Tests file copy operations between local and remote instance. | ||
| Returns: | ||
| (passed: bool, reason: str) | ||
| """ |
There was a problem hiding this comment.
The PR title contains a spelling error: 'verififcation' should be 'verification'.
Comment on lines
+7311
to
+7314
| progress_print(args, f"[MACHINE TESTER] Cleaning up instance {instance_id} in finally block") | ||
| destroy_instance_silent(instance_id, destroy_args) | ||
| progress_print(args, f"Machine: {machine_id} Done with testing remote.py results {message}") | ||
| else: | ||
| progress_print(args, f"[MACHINE TESTER] Instance {instance_id} already destroyed or doesn't exist") |
There was a problem hiding this comment.
Inconsistent indentation in the finally block. The lines inside the if statement should be properly indented to match Python standards.
robballantyne
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.