chore(pkg): ⬆️ Upgrading Aegir and Sinon#99
Closed
whizzzkid wants to merge 1 commit intovasco-santos:mainfrom
Closed
chore(pkg): ⬆️ Upgrading Aegir and Sinon#99whizzzkid wants to merge 1 commit intovasco-santos:mainfrom
whizzzkid wants to merge 1 commit intovasco-santos:mainfrom
Conversation
Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
achingbrain
reviewed
Oct 26, 2023
| * @param {string} [rrType = 'A'] - resource record type | ||
| */ | ||
| async resolve (hostname: string, rrType = 'A') { | ||
| async resolve (hostname: string, rrType = 'A'): Promise<string[] | string[][]> { |
Collaborator
There was a problem hiding this comment.
Instead of returning Promise<string[] | string[][]> we can use method overloading to return a specific type based on the rrType parameter. This way the user doesn't have to work out what they were given:
Suggested change
| async resolve (hostname: string, rrType = 'A'): Promise<string[] | string[][]> { | |
| async resolve (hostname: string, rrType: 'TXT'): Promise<string[][]> | |
| async resolve (hostname: string, rrType: 'A' | 'AAAA'): Promise<string[]> | |
| async resolve (hostname: string): Promise<string[]> | |
| async resolve (hostname: string, rrType: string = 'A'): Promise<string[] | string[][]> { |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR: