Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge #2

Merged
merged 22 commits into from
Nov 28, 2022
Merged

merge #2

merged 22 commits into from
Nov 28, 2022

Conversation

varghvi
Copy link
Owner

@varghvi varghvi commented Nov 28, 2022

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

dependabot bot and others added 22 commits November 18, 2022 13:29
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Boris Serdiuk <[email protected]>
…loudscape-design#493)

This PR fixes the unexpected table header overscroll when the table has few items and split panel gets opened at bottom position. See PR details for more information.
…ontainer (cloudscape-design#501)

Before this change, the sticky background got reset when mounting and unmounting
another component which uses the InternalContainer. This resulted in a header 
background which did not had the full width after unmounting.
See cloudscape-design#505 for details.
…ign#513)

Screenshot tests failed because of non-deterministic
table items. When toggling in between the item count
the items did not stay the same. This commit fixed that
behaviour and the related failing screenshot tests.
@varghvi varghvi merged commit b8df632 into AWSUI-19118 Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants