Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow OMIM: prefix in the omim_id of the hpo/omims endpoint #178

Closed
stolpeo opened this issue Jul 12, 2024 · 1 comment · Fixed by #179
Closed

allow OMIM: prefix in the omim_id of the hpo/omims endpoint #178

stolpeo opened this issue Jul 12, 2024 · 1 comment · Fixed by #179
Labels
enhancement New feature or request

Comments

@stolpeo
Copy link

stolpeo commented Jul 12, 2024

Is your feature request related to a problem? Please describe.

Currently, OMIM and MIM terms are only accepted without the prefix (i.e. just the digits) in the endpoint /hpo/omims. Make the endpoint consistent with the HPO terms endpoint that accepts the HP: prefix by allowing the OMIM: / MIM: prefix and stripping it, i.e. allow queries like /hpo/omims?omim_id=OMIM:616145.
@stolpeo stolpeo added the enhancement New feature or request label Jul 12, 2024
@holtgrewe
Copy link
Collaborator

cf. varfish-org/varfish-server#1792

holtgrewe added a commit that referenced this issue Jul 14, 2024
@holtgrewe
fix: allow "OMIM:" and "MIM:" prefixes in omim_id param (#178)
6c17d76
@holtgrewe holtgrewe linked a pull request Jul 14, 2024 that will close this issue
fix: allow "OMIM:" and "MIM:" prefixes in omim_id param (#178) #179
Merged
holtgrewe added a commit that referenced this issue Jul 14, 2024
@holtgrewe
fix: allow "OMIM:" and "MIM:" prefixes in omim_id param (#178) (#179)
5cbd43d
@varfish-bot varfish-bot mentioned this issue Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow "OMIM:" and "MIM:" prefixes in omim_id param (#178) varfish-org/viguno
2 participants
@holtgrewe @stolpeo