Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for versions of query settings and delete the old if they mismatch #1807

Closed
stolpeo opened this issue Jul 17, 2024 · 1 comment · Fixed by #1855
Closed

Check for versions of query settings and delete the old if they mismatch #1807

stolpeo opened this issue Jul 17, 2024 · 1 comment · Fixed by #1855
Assignees
@stolpeo
Labels
enhancement New feature or request

Comments

@stolpeo
Copy link
Contributor

stolpeo commented Jul 17, 2024

Is your feature request related to a problem? Please describe.
Related to #1662 . Query settings are versioned, however, currently this feature is not used. Before loading old query settings, check the version and remove the ones that do not match the newest version to prevent unpredictable behavior.
@stolpeo stolpeo added the enhancement New feature or request label Jul 17, 2024
@stolpeo stolpeo mentioned this issue Jul 17, 2024
Open
@stolpeo stolpeo self-assigned this Jul 25, 2024
stolpeo added a commit that referenced this issue Jul 31, 2024
@stolpeo
feat: command to delete invalid queries with invalid settings (#1807)
71cd435
@xiamaz
Copy link
Collaborator

xiamaz commented Aug 1, 2024

@stolpeo will discuss with @holtgrewe

stolpeo added a commit that referenced this issue Aug 1, 2024
@stolpeo
feat: command to delete invalid queries with invalid settings (#1807)
2a2cab0
stolpeo added a commit that referenced this issue Aug 1, 2024
@stolpeo
feat: command to delete invalid queries with invalid settings (#1807)
ad11dcf
@stolpeo stolpeo linked a pull request Aug 1, 2024 that will close this issue
feat: command to delete invalid queries with invalid settings (#1807) #1855
Merged
stolpeo added a commit that referenced this issue Aug 1, 2024
@stolpeo
feat: command to delete invalid queries with invalid settings (#1807) (…
9b7f085 
…#1855)
@varfish-bot varfish-bot mentioned this issue Aug 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stolpeo stolpeo

Labels
enhancement New feature or request
Projects
Release Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: command to delete invalid queries with invalid settings (#1807) varfish-org/varfish-server
2 participants
@stolpeo @xiamaz